-
-
Notifications
You must be signed in to change notification settings - Fork 975
feat: promote rules for v2.4 #9011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fe47cbe
feat: promote rules
ematipico 00a67ed
revert change, add changeset, add issue number
ematipico bbf8432
[autofix.ci] apply automated fixes
autofix-ci[bot] 9545f68
refactor: set severity level of promoted rules
Conaclos 12fa7bd
Don't change non-promted rules
Conaclos 0436189
Update test snapshots
Conaclos d387918
Update changeset
Conaclos 1053073
fix test
ematipico f7af505
[autofix.ci] apply automated fixes
autofix-ci[bot] 76d9560
demote noShadow
ematipico 214bb5c
update severity of correctness rule
ematipico 1d70f8d
fix compilation and linting
ematipico 47921f9
[autofix.ci] apply automated fixes
autofix-ci[bot] 3c8cf59
fix linting of rules and invalid cases
ematipico 2375fab
update config
ematipico 6b1a21f
update snapsthos
ematipico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| --- | ||
| "@biomejs/biome": minor | ||
| --- | ||
|
|
||
| Promoted 21 nursery rules to stable groups. | ||
|
|
||
| #### Correctness | ||
|
|
||
| Promoted the following rules to the `correctness` group: | ||
|
|
||
| - [`noUnresolvedImports`](https://biomejs.dev/linter/rules/no-unresolved-imports/). The rule reports imports that cannot be resolved. | ||
| The default rule severity is set to `error`. | ||
| - [`noVueReservedProps`](https://biomejs.dev/linter/rules/no-vue-reserved-props/). The rule reports Vue reserved props usage. | ||
| The default rule severity is set to `error`. | ||
| - [`noVueReservedKeys`](https://biomejs.dev/linter/rules/no-vue-reserved-keys/). The rule reports Vue reserved keys usage. | ||
| The default rule severity is set to `error`. | ||
| - [`noVueDataObjectDeclaration`](https://biomejs.dev/linter/rules/no-vue-data-object-declaration/). The rule reports Vue 2 data declared as an object instead of a function. | ||
| The default rule severity is set to `warn`. | ||
| - [`noNextAsyncClientComponent`](https://biomejs.dev/linter/rules/no-next-async-client-component/). The rule reports async Next.js client components. | ||
| The default rule severity is set to `warn`. | ||
| - [`noVueDuplicateKeys`](https://biomejs.dev/linter/rules/no-vue-duplicate-keys/). The rule reports duplicate keys in Vue component options. | ||
| The default rule severity is set to `error`. | ||
| - [`noVueSetupPropsReactivityLoss`](https://biomejs.dev/linter/rules/no-vue-setup-props-reactivity-loss/). The rule reports destructuring of props in Vue 3 setup which causes reactivity loss. | ||
| The default rule severity is set to `error`. | ||
| - [`useQwikMethodUsage`](https://biomejs.dev/linter/rules/use-qwik-method-usage/). The rule enforces correct Qwik framework method usage. | ||
| The default rule severity is set to `error`. | ||
| - [`useQwikValidLexicalScope`](https://biomejs.dev/linter/rules/use-qwik-valid-lexical-scope/). The rule enforces valid lexical scope in Qwik framework. | ||
| The default rule severity is set to `error`. | ||
|
|
||
| #### Suspicious | ||
|
|
||
| Promoted the following rules to the `suspicious` group: | ||
|
|
||
| - [`noImportCycles`](https://biomejs.dev/linter/rules/no-import-cycles/). The rule reports circular imports. | ||
| The default rule severity is set to `warn`. | ||
| - [`noDeprecatedImports`](https://biomejs.dev/linter/rules/no-deprecated-imports/). The rule reports imports of deprecated symbols. | ||
| The default rule severity is set to `warn`. | ||
| - [`noReactForwardRef`](https://biomejs.dev/linter/rules/no-react-forward-ref/). The rule reports usage of `React.forwardRef`. | ||
| The default rule severity is set to `warn`. | ||
| - [`noUnusedExpressions`](https://biomejs.dev/linter/rules/no-unused-expressions/). The rule reports expressions that are never used. | ||
| The default rule severity is set to `warn`. | ||
| - [`noEmptySource`](https://biomejs.dev/linter/rules/no-empty-source/). The rule reports empty source files. | ||
| The default rule severity is set to `warn`. | ||
| - [`useDeprecatedDate`](https://biomejs.dev/linter/rules/use-deprecated-date/). The rule enforces use of GraphQL `@deprecated` directive with date. | ||
| The default rule severity is set to `warn`. | ||
| - [`noDuplicateDependencies`](https://biomejs.dev/linter/rules/no-duplicate-dependencies/). The rule reports duplicate dependencies in package.json. | ||
| The default rule severity is set to `warn`. | ||
|
|
||
| #### Complexity | ||
|
|
||
| Promoted the following rules to the `complexity` group: | ||
|
|
||
| - [`noUselessUndefined`](https://biomejs.dev/linter/rules/no-useless-undefined/). The rule reports useless `undefined` initialization and returns. | ||
| The default rule severity is set to `info`. | ||
| - [`useMaxParams`](https://biomejs.dev/linter/rules/use-max-params/). The rule enforces a maximum number of function parameters. | ||
| The default rule severity is set to `warn`. | ||
| - [`noUselessCatchBinding`](https://biomejs.dev/linter/rules/no-useless-catch-binding/). The rule reports useless catch binding parameters. | ||
| The default rule severity is set to `info`. | ||
|
|
||
| #### Style | ||
|
|
||
| Promoted the following rules to the `style` group: | ||
|
|
||
| - [`useConsistentArrowReturn`](https://biomejs.dev/linter/rules/use-consistent-arrow-return/). The rule enforces consistent return in arrow functions. | ||
| The default rule severity is set to `info`. | ||
| - [`noJsxLiterals`](https://biomejs.dev/linter/rules/no-jsx-literals/). The rule reports literal strings in JSX. | ||
| The default rule severity is set to `info`. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.