Skip to content

fix(core): scss handling#9091

Merged
ematipico merged 1 commit intomainfrom
fix/scss-being-processed
Feb 16, 2026
Merged

fix(core): scss handling#9091
ematipico merged 1 commit intomainfrom
fix/scss-being-processed

Conversation

@ematipico
Copy link
Copy Markdown
Member

Summary

Closes #9090

Test Plan

Added an harness test so we catch it

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 16, 2026

🦋 Changeset detected

Latest commit: 59f20e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added A-CLI Area: CLI A-Parser Area: parser L-CSS Language: CSS and super languages labels Feb 16, 2026
@ematipico ematipico changed the title fix(core): SCSS handling fix(core): scss handling Feb 16, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Adds a changelog entry for a patch release addressing a regression (issue #9090); introduces a test (harness_scss) that asserts SCSS files produce a not-yet-supported error; adds an scss feature flag to crates/biome_css_syntax/Cargo.toml (placeholder); and gates SCSS match arms in crates/biome_css_syntax/src/file_source.rs behind #[cfg(feature = "scss")] so SCSS handling is compiled only when the feature is enabled.

Possibly related PRs

Suggested reviewers

  • dyc3
  • siketyan
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix(core): scss handling' is vague and generic, using non-descriptive language that doesn't convey the specific issue being addressed. Clarify the title to specify the actual fix, e.g. 'fix: prevent scss files from being processed incorrectly' or 'fix: restore scss interpolation support'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description references issue #9090 and mentions adding a harness test, which relates to the changeset addressing SCSS handling regression.
Linked Issues check ✅ Passed The PR addresses issue #9090 by adding feature-gated SCSS support and a test harness to prevent regression, aligning with the requirement to restore SCSS interpolation parsing.
Out of Scope Changes check ✅ Passed All changes are scoped to SCSS handling: feature flag addition, file source conditionals, changelog entry, and regression test—no extraneous modifications detected.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/scss-being-processed

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @.changeset/silver-sites-taste.md:
- Line 5: Update the changeset note that starts with "Fixed
[](https://github.com/biomejs/biome/issues/9090), where SCSS files were
incorrectly processed by Biome." — change "a regressions" to "a regression" and
slightly rephrase the clause to read smoothly (for example: "This was a
regression caused by recent changes to SCSS support" or similar) so the sentence
is grammatically correct and clearer.

In `@crates/biome_cli/tests/commands/format.rs`:
- Around line 4037-4055: The test harness_scss currently asserts only
result.is_err() and has a typo in the failure message; update it to (1) fix the
typo in the assertion message and (2) assert the error or console output
contains the expected SCSS-unsupported message to lock behavior: capture the
error via result.unwrap_err() (or format the console buffer from BufferConsole)
and assert it contains a stable substring like "SCSS support is not available"
(or the real message returned by run_cli/Args), or replace the ad-hoc check with
a snapshot/assert_eq against the expected output to prevent regressions;
reference harness_scss, run_cli, Args, BufferConsole, and MemoryFileSystem when
locating and making this change.

Comment thread .changeset/silver-sites-taste.md Outdated
Comment thread crates/biome_cli/tests/commands/format.rs
@ematipico ematipico force-pushed the fix/scss-being-processed branch from e45c7da to 59f20e2 Compare February 16, 2026 09:12
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 16, 2026

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 126 skipped benchmarks1


Comparing fix/scss-being-processed (59f20e2) with main (4cc531c)2

Open in CodSpeed

Footnotes

  1. 126 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (e332a23) during the generation of this report, so 4cc531c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ematipico ematipico merged commit 3bf674d into main Feb 16, 2026
16 checks passed
@ematipico ematipico deleted the fix/scss-being-processed branch February 16, 2026 09:19
@github-actions github-actions Bot mentioned this pull request Feb 16, 2026
@Netail Netail added the L-SCSS label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CLI Area: CLI A-Parser Area: parser L-CSS Language: CSS and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 2.4 fails to parse scss interpolation correctly

3 participants