crates/biome_markdown_parser/src/syntax/mod.rs (1)

536-538: Use TAB_STOP_SPACES in indent prefix helper for full consistency.

consume_indent_prefix still hardcodes 4 at Line 537, which undercuts the centralisation done elsewhere.

♻️ Suggested patch

-        } else if text == "\t" {
-            consumed += 4;
+        } else if text == "\t" {
+            consumed += TAB_STOP_SPACES;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_markdown_parser/src/syntax/mod.rs` around lines 536 - 538, The
indent helper consume_indent_prefix currently hardcodes adding 4 when
encountering a tab; replace that literal with the centralized constant
TAB_STOP_SPACES so the function uses the same tab width as the rest of the
codebase (i.e., change the branch that checks text == "\t" to add
TAB_STOP_SPACES to consumed and otherwise leave logic unchanged). Ensure you
reference consume_indent_prefix and TAB_STOP_SPACES so the change is consistent
and compiles.

crates/biome_markdown_parser/src/parser.rs (1)

468-474: Use TAB_STOP_SPACES in count_leading_indent as well.

Line [473] still hardcodes 4; swapping to the shared constant keeps tab semantics single-sourced.

♻️ Suggested patch

 fn count_leading_indent(text: &str) -> usize {
     let mut count = 0usize;
     for c in text.chars() {
         match c {
             ' ' => count += 1,
-            '\t' => count += 4,
+            '\t' => count += TAB_STOP_SPACES,
             _ => break,
         }
     }
     count
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_markdown_parser/src/parser.rs` around lines 468 - 474, In
count_leading_indent, replace the hardcoded tab width (currently adding 4 for
'\t') with the shared constant TAB_STOP_SPACES so tab semantics are
single-sourced; update the match arm for '\t' to add TAB_STOP_SPACES and ensure
the function can see the constant (use the existing TAB_STOP_SPACES in scope or
import it) so behavior stays consistent across the crate.

crates/biome_markdown_parser/src/to_html.rs (1)

1151-1151: Minor: Literal 3 could use MAX_BLOCK_PREFIX_INDENT for consistency.

Line 1151 still uses .min(3) to clamp fence indentation. This is semantically the same as MAX_BLOCK_PREFIX_INDENT. Consider replacing it for consistency with the rest of the refactor.

let fence_indent = fence_leading_indent.saturating_sub(container_indent).min(MAX_BLOCK_PREFIX_INDENT);

Not blocking—feel free to defer if you deliberately left derived/clamping values as literals.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_markdown_parser/src/to_html.rs` at line 1151, Replace the magic
literal 3 used to clamp the fence indentation with the canonical constant
MAX_BLOCK_PREFIX_INDENT for consistency: in the computation of fence_indent
(which uses fence_leading_indent.saturating_sub(container_indent).min(...)),
change the .min(3) call to .min(MAX_BLOCK_PREFIX_INDENT) so the code uses the
shared constant rather than a hard-coded value.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro