feat(assist): use sorted type fields 9137 by ff1451 · Pull Request #9275 · biomejs/biome

ff1451 · 2026-02-28T15:37:37Z

I used Claude Code to assist with generating test cases and documentation.

Summary

Implements the useSortedTypeFields assist action for GraphQL as part of #9137.

This action alphabetically sorts fields of:

ObjectTypeDefinition
InterfaceTypeDefinition
InputObjectTypeDefinition
and their corresponding extensions

The ordering matches JavaScript’s localeCompare() behavior for GraphQL identifiers ([_A-Za-z0-9]):

Primary order: _ < digits < letters (case-insensitive)
Tiebreaker: lowercase before uppercase (e.g. aField before AField)

This PR also introduces the assist category infrastructure for biome_graphql_analyze, which previously only supported lint rules.

Why this is implemented as an assist

Sorting fields is a non-semantic, style-only transformation with a clear and safe auto-fix. It does not indicate a bug or problematic pattern — it only improves structural consistency and readability.

For that reason, I implemented it as an assist action rather than a lint rule. If this classification is incorrect (for example, if it should follow thenursery rule policy or be modeled as a lint rule instead), please let me know. I’m happy to adjust the implementation accordingly.

Branch Target

This PR currently targets next, since adding a new assist action is a user-facing feature (minor change).

If new assist actions are expected to target main instead (e.g. if they follow the same release policy as nursery rules), I’m happy to retarget the branch.

Test Plan

Snapshot tests cover:

Unsorted ObjectTypeDefinition
Unsorted InterfaceTypeDefinition
Unsorted InputObjectTypeDefinition
Unsorted ObjectTypeExtension
Unsorted InterfaceTypeExtension
Unsorted InputObjectTypeExtension
Mixed-case ordering (apple before Zoo)
Case tiebreaker (aField before AField)
localeCompare character class ordering (a_ before a1)

Documentation

Inline rustdoc documentation is provided in use_sorted_type_fields.rs,
including expect_diff examples demonstrating the before/after transformation.

changeset-bot · 2026-02-28T15:37:42Z

🦋 Changeset detected

Latest commit: c24a3d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
@biomejs/biome	Minor
@biomejs/cli-win32-x64	Minor
@biomejs/cli-win32-arm64	Minor
@biomejs/cli-darwin-x64	Minor
@biomejs/cli-darwin-arm64	Minor
@biomejs/cli-linux-x64	Minor
@biomejs/cli-linux-arm64	Minor
@biomejs/cli-linux-x64-musl	Minor
@biomejs/cli-linux-arm64-musl	Minor
@biomejs/wasm-web	Minor
@biomejs/wasm-bundler	Minor
@biomejs/wasm-nodejs	Minor
@biomejs/backend-jsonrpc	Patch
@biomejs/js-api	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-02-28T15:42:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 16af1509-c740-4b8b-8f1f-52a92edbd8f7

📥 Commits

Reviewing files that changed from the base of the PR and between b9a73d9 and c24a3d5.

📒 Files selected for processing (1)

.changeset/afraid-humans-worry.md

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/afraid-humans-worry.md

Walkthrough

Adds a new GraphQL assist useSortedTypeFields that detects unsorted fields in object, interface and input object definitions (including extensions) and can auto-fix by replacing them with a locale-aware alphabetically sorted list. Changes include a new ActionName variant, analyzer Assist category and group registration, the rule implementation and state/query types, options struct, codegen updates, build/watch group update, and new test fixtures for valid/invalid cases.

Possibly related PRs

perf(core): refactor fix-all logic #9755: Integrates Assist category changes and adds fixable assists in the analyzer visitor/fix-all two-phase flow — directly related to assist registration and fix mechanics.
feat(assist): implement useSortedAttributes for HTML #9547: Adds another assist and adjusts ActionName/as_str/group/FromStr handling, overlapping enum and action wiring touched here.

Suggested reviewers

dyc3

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: implementing a new assist action for sorting GraphQL type fields, with reference to the issue number.
Description check	✅ Passed	The description is comprehensive and directly related to the changeset, explaining the assist action's purpose, sorting behaviour, and implementation rationale.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

crates/biome_graphql_analyze/src/assist/source/use_sorted_type_fields.rs (1)

79-131: Consider extracting common pattern.

The six match arms follow identical structure. A helper method could reduce duplication, though current readability is fine.

♻️ Optional: Extract helper for common pattern

fn check_fields<T, F>(fields: Option<T>, check_sorted: F) -> Option<UseSortedTypeFieldsState>
where
    F: FnOnce(&T) -> bool,
    T: Into<UseSortedTypeFieldsState>,
{
    let fields = fields?;
    if check_sorted(&fields) {
        None
    } else {
        Some(fields.into())
    }
}

This would require implementing Into<UseSortedTypeFieldsState> for the field types, which may be more boilerplate than it's worth.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_graphql_analyze/src/assist/source/use_sorted_type_fields.rs`
around lines 79 - 131, The six match arms in run (handling
UseSortedTypeFieldsQuery::{GraphqlObjectTypeDefinition,
GraphqlObjectTypeExtension, GraphqlInterfaceTypeDefinition,
GraphqlInterfaceTypeExtension, GraphqlInputObjectTypeDefinition,
GraphqlInputObjectTypeExtension}) duplicate the same pattern; extract a helper
like check_fields that takes the optional fields, a predicate
(is_field_definition_list_sorted or is_input_field_list_sorted) and a closure or
an Into/From conversion to produce the appropriate UseSortedTypeFieldsState
(UseSortedTypeFieldsState::TypeFields or ::InputFields) so each arm reduces to
calling check_fields(fields_option, predicate, state_mapper). Ensure helper
handles the Option early-return (fields?) and returns Some(state) or None
matching current behavior; reference functions is_field_definition_list_sorted,
is_input_field_list_sorted and enum UseSortedTypeFieldsState for integration.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@crates/biome_graphql_analyze/src/assist/source/use_sorted_type_fields.rs`:
- Around line 79-131: The six match arms in run (handling
UseSortedTypeFieldsQuery::{GraphqlObjectTypeDefinition,
GraphqlObjectTypeExtension, GraphqlInterfaceTypeDefinition,
GraphqlInterfaceTypeExtension, GraphqlInputObjectTypeDefinition,
GraphqlInputObjectTypeExtension}) duplicate the same pattern; extract a helper
like check_fields that takes the optional fields, a predicate
(is_field_definition_list_sorted or is_input_field_list_sorted) and a closure or
an Into/From conversion to produce the appropriate UseSortedTypeFieldsState
(UseSortedTypeFieldsState::TypeFields or ::InputFields) so each arm reduces to
calling check_fields(fields_option, predicate, state_mapper). Ensure helper
handles the Option early-return (fields?) and returns Some(state) or None
matching current behavior; reference functions is_field_definition_list_sorted,
is_input_field_list_sorted and enum UseSortedTypeFieldsState for integration.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cd3da1 and b9a73d9.

⛔ Files ignored due to path filters (3)

crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
crates/biome_graphql_analyze/tests/specs/source/useSortedTypeFields/invalid.graphql.snap is excluded by !**/*.snap and included by **
crates/biome_graphql_analyze/tests/specs/source/useSortedTypeFields/valid.graphql.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (13)

.changeset/afraid-humans-worry.md
crates/biome_configuration/src/analyzer/assist/actions.rs
crates/biome_graphql_analyze/build.rs
crates/biome_graphql_analyze/src/assist.rs
crates/biome_graphql_analyze/src/assist/source.rs
crates/biome_graphql_analyze/src/assist/source/use_sorted_type_fields.rs
crates/biome_graphql_analyze/src/lib.rs
crates/biome_graphql_analyze/src/registry.rs
crates/biome_graphql_analyze/tests/specs/source/useSortedTypeFields/invalid.graphql
crates/biome_graphql_analyze/tests/specs/source/useSortedTypeFields/valid.graphql
crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/use_sorted_type_fields.rs
xtask/codegen/src/generate_analyzer.rs

codspeed-hq · 2026-02-28T15:44:52Z

Merging this PR will not alter performance

✅ 9 untouched benchmarks
⏩ 219 skipped benchmarks¹

_{Comparing ff1451:feat/use-sorted-type-fields-9137 (c24a3d5) with next (01f8473)}

219 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Netail · 2026-03-31T12:49:42Z

Sorry for the long wait, looks good :)

Netail

Perhaps some comments around some fields in tests, so we make sure that comments are moved with the memebers

ff1451 added 3 commits March 1, 2026 00:23

chore(graphql/analyze): add assist category infrastructure

9639244

feat(graphql/assist): implement useSortedTypeFields

3277ce6

test(graphql/assist): add useSortedTypeFields fixtures

b9a73d9

github-actions Bot added A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools A-Diagnostic Area: diagnostocis labels Feb 28, 2026

coderabbitai Bot reviewed Feb 28, 2026

View reviewed changes

[autofix.ci] apply automated fixes

f91741a

ff1451 changed the title ~~feat(lint): use sorted type fields 9137~~ feat(assist): use sorted type fields 9137 Feb 28, 2026

Netail approved these changes Mar 31, 2026

View reviewed changes

Comment thread .changeset/afraid-humans-worry.md Outdated

Netail reviewed Mar 31, 2026

View reviewed changes

Comment thread crates/biome_graphql_analyze/src/assist/source/use_sorted_type_fields.rs Outdated

Comment thread crates/biome_graphql_analyze/src/assist/source/use_sorted_type_fields.rs Outdated

Netail requested a review from a team March 31, 2026 17:44

Netail and others added 2 commits April 6, 2026 16:57

Merge branch 'next' into feat/use-sorted-type-fields-9137

f74650f

fix: feedback

c24a3d5

Netail force-pushed the feat/use-sorted-type-fields-9137 branch from 35917ef to c24a3d5 Compare April 6, 2026 15:23

dyc3 approved these changes Apr 6, 2026

View reviewed changes

Netail merged commit 1fdbcee into biomejs:next Apr 6, 2026
17 checks passed

coderabbitai Bot mentioned this pull request Apr 6, 2026

fix: assist generator #9831

Merged

Netail mentioned this pull request Apr 7, 2026

📎 Port GraphQL Eslint's alphabetize #9137

Open

6 tasks

coderabbitai Bot mentioned this pull request Apr 7, 2026

feat(graphql_analyze): implement useSortedSelectionSet #9853

Merged

coderabbitai Bot mentioned this pull request Apr 15, 2026

feat: implement useSortedEnumMembers #10000

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(assist): use sorted type fields 9137#9275

feat(assist): use sorted type fields 9137#9275
Netail merged 6 commits intobiomejs:nextfrom
ff1451:feat/use-sorted-type-fields-9137

ff1451 commented Feb 28, 2026

Uh oh!

changeset-bot Bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

codspeed-hq Bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Netail commented Mar 31, 2026

Uh oh!

Netail left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ff1451 commented Feb 28, 2026

Summary

Why this is implemented as an assist

Branch Target

Test Plan

Documentation

Uh oh!

changeset-bot Bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq Bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Netail commented Mar 31, 2026

Uh oh!

Netail left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot Bot commented Feb 28, 2026 •

edited

Loading

coderabbitai Bot commented Feb 28, 2026 •

edited

Loading

codspeed-hq Bot commented Feb 28, 2026 •

edited

Loading