chore(benchmark): upgrade to Debian 13 Trixie, Node.js 24#9499
Conversation
|
WalkthroughThe Dockerfile.benchmark has been updated to use more recent versions of its base dependencies. The Rust base image has been bumped from the Bookworm distribution to Trixie, whilst the Node.js setup has been advanced from version 22.x to version 24.x. These changes represent straightforward version increments with no modifications to the overall structure or remaining steps in the build configuration. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile.benchmark (1)
6-6: Add--no-install-recommendsto reduce image size.Trim unnecessary packages from the Node.js installation to keep the benchmark image lean. Node.js 24 is LTS and the setup script is accessible, so no concerns there.
-RUN curl -fsSL https://deb.nodesource.com/setup_24.x | bash - && apt-get install -y nodejs +RUN curl -fsSL https://deb.nodesource.com/setup_24.x | bash - && apt-get install -y --no-install-recommends nodejs🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile.benchmark` at line 6, Update the Dockerfile RUN line that installs Node.js so the apt-get install invocation uses the --no-install-recommends flag to avoid pulling recommended packages; specifically change the RUN command installing nodejs (the line that pipes the NodeSource setup script and runs apt-get install -y nodejs) to include --no-install-recommends (i.e., apt-get install -y --no-install-recommends nodejs) so the benchmark image stays lean.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Dockerfile.benchmark`:
- Line 6: Update the Dockerfile RUN line that installs Node.js so the apt-get
install invocation uses the --no-install-recommends flag to avoid pulling
recommended packages; specifically change the RUN command installing nodejs (the
line that pipes the NodeSource setup script and runs apt-get install -y nodejs)
to include --no-install-recommends (i.e., apt-get install -y
--no-install-recommends nodejs) so the benchmark image stays lean.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 60e3df78-913f-451e-81da-532d97618ed9
📒 Files selected for processing (1)
Dockerfile.benchmark
Summary
Upgraded the base image of the Dockerfile for benchmarks to Debian 13 Trixie. Also upgraded Node.js installation to 24, the latest LTS.
Test Plan
CIs should stays green
Docs
N/A