fix: missing rule source reference by Netail · Pull Request #9504 · biomejs/biome

Netail · 2026-03-16T09:11:10Z

Summary

Missing rule source

Test Plan

Docs

changeset-bot · 2026-03-16T09:11:17Z

⚠️ No Changeset found

Latest commit: 1e9e6c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-16T09:15:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ffabd3fc-945b-41b0-a159-8ba5930ca571

📥 Commits

Reviewing files that changed from the base of the PR and between 52e34eb and 60941b3.

📒 Files selected for processing (1)

crates/biome_js_analyze/src/assist/source/use_sorted_keys.rs

🚧 Files skipped from review as they are similar to previous changes (1)

crates/biome_js_analyze/src/assist/source/use_sorted_keys.rs

Walkthrough

This PR adds a changeset declaring a patch update for @biomejs/biome and updates the UseSortedKeys rule in the JavaScript analyser to include both RuleSource::Eslint("sort-keys") and RuleSource::EslintPerfectionist("sort-objects") as recognised sources.

Possibly related PRs

docs: rules.rs cleanup #8044 — Introduces RuleSource::Eslint("sort-keys") alongside existing EslintPerfectionist variants, matching the change to rule source variants.
chore: extra rule sources #8740 — Expands rule source arrays by adding additional ESLint-based RuleSource entries to rule declarations.
chore: add extra eslint plugin sources #9362 — Modifies use_sorted_keys to include new ESLint plugin sources and RuleSource variants.

Suggested reviewers

ematipico
dyc3

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: missing rule source reference' directly matches the changeset, which adds a missing Eslint source reference to the UseSortedKeys rule.
Description check	✅ Passed	The description mentions 'Missing rule source', which aligns with the changeset adding a missing Eslint source reference to the UseSortedKeys rule.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/assist-rule-source

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/yellow-submarine-cookie.md:
- Line 5: Replace the current changeset description that begins with "Extra rule
source reference." so the first line follows the bug-fix format "Fixed
[`#NUMBER`](issue link): ..." and rewrite the body into 1–3 user-facing sentences
describing the user impact and what changed (avoid implementation/internal
details like "rule source reference"); ensure the message clearly states the
problem users experienced and the visible fix, then save the revised content in
the same changeset file.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a6253e87-59a2-4b6e-ba8f-7584492269f7

📥 Commits

Reviewing files that changed from the base of the PR and between cd51722 and 52e34eb.

📒 Files selected for processing (2)

.changeset/yellow-submarine-cookie.md
crates/biome_js_analyze/src/assist/source/use_sorted_keys.rs

codspeed-hq · 2026-03-16T09:25:56Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 156 skipped benchmarks¹

_{Comparing fix/assist-rule-source (1e9e6c2) with main (ab25a3e)²}

156 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (cd51722) during the generation of this report, so ab25a3e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

ematipico · 2026-03-16T09:57:53Z

+"@biomejs/biome": patch
+---
+
+Extra rule source reference. `biome migrate eslint` should do a bit better detecting rules in your eslint configurations.


Please adhere to the contribution guidelines for changesets:

use the past tense

the phrase needs to target the end users.

For example "Extra rule source reference" doesn't mean anything to our users, as well as the second. Be precise (mention maybe which rules we are about to migrate)

Mhm alright, have been using this changeset sentence when adding rule sources a few times already and I think once suggested by a core member 😅

Honestly, idk if the changeset is actually needed as inspired rule kinds won't be used in the migrate command (deleted the changeset)

If so, we can then remove the changset. The change is mostly for docs, then, which doesn't affect this package

fix: missing rule source reference

52e34eb

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Mar 16, 2026

coderabbitai Bot reviewed Mar 16, 2026

View reviewed changes

Comment thread .changeset/yellow-submarine-cookie.md Outdated

.

60941b3

ematipico requested changes Mar 16, 2026

View reviewed changes

remove changeset

1e9e6c2

ematipico approved these changes Mar 16, 2026

View reviewed changes

Netail merged commit c311974 into main Mar 16, 2026
17 checks passed

Netail deleted the fix/assist-rule-source branch March 16, 2026 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: missing rule source reference#9504

fix: missing rule source reference#9504
Netail merged 3 commits intomainfrom
fix/assist-rule-source

Netail commented Mar 16, 2026

Uh oh!

changeset-bot Bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

ematipico Mar 16, 2026

Uh oh!

Netail Mar 16, 2026 •

edited

Loading

Uh oh!

ematipico Mar 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Netail commented Mar 16, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

ematipico Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Netail Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ematipico Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Mar 16, 2026 •

edited

Loading

coderabbitai Bot commented Mar 16, 2026 •

edited

Loading

codspeed-hq Bot commented Mar 16, 2026 •

edited

Loading

Netail Mar 16, 2026 •

edited

Loading

ematipico Mar 16, 2026 •

edited

Loading