crates/biome_cli/tests/cases/reporter_concise.rs (1)

29-170: Optional tidy-up: factor shared test scaffolding into a helper.

The setup/run/assert pattern is repeated four times; a tiny helper would trim noise and make future reporter cases easier to add.

♻️ Possible refactor sketch

+fn run_concise(command: &str, snapshot_name: &str) {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    let file_path1 = Utf8Path::new("main.ts");
+    fs.insert(file_path1.into(), MAIN_1.as_bytes());
+    let file_path2 = Utf8Path::new("index.ts");
+    fs.insert(file_path2.into(), MAIN_2.as_bytes());
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from([command, "--reporter=concise", file_path1.as_str(), file_path2.as_str()].as_slice()),
+    );
+
+    assert!(result.is_err(), "run_cli returned {result:?}");
+    assert_cli_snapshot(SnapshotPayload::new(module_path!(), snapshot_name, fs, console, result));
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_cli/tests/cases/reporter_concise.rs` around lines 29 - 170,
Extract the repeated test scaffolding in
reports_diagnostics_concise_check_command,
reports_diagnostics_concise_ci_command,
reports_diagnostics_concise_lint_command, and
reports_diagnostics_concise_format_command into a small helper (e.g., a function
like run_concise_report_test) that takes the command name
("check"/"ci"/"lint"/"format") and snapshot name, creates MemoryFileSystem and
BufferConsole, inserts MAIN_1/MAIN_2, calls run_cli with Args::from([...
"--reporter=concise", file_path1, file_path2]), asserts result is Err, and calls
assert_cli_snapshot(SnapshotPayload::new(...)); then replace each test body with
a single call to that helper to reduce duplication while keeping run_cli,
Args::from, and assert_cli_snapshot usage intact.

crates/biome_diagnostics/src/display.rs (2)

282-287: ⚠️ Potential issue | 🟡 Minor

Avoid unconditional ": " separators in concise output.

Line 282 and Line 287 always print delimiters, so diagnostics without location/category render as awkward placeholders (for example ✖ : ...).

💡 Proposed fix

-    // Print file location with hyperlink
-    print_file_location(fmt, diagnostic)?;
-
-    fmt.write_str(": ")?;
-
-    // Print category with hyperlink
-    print_category(fmt, diagnostic)?;
-
-    fmt.write_str(": ")?;
+    let has_file = matches!(diagnostic.location().resource, Some(Resource::File(_)));
+    if has_file {
+        print_file_location(fmt, diagnostic)?;
+        fmt.write_str(": ")?;
+    }
+
+    if diagnostic.category().is_some() {
+        print_category(fmt, diagnostic)?;
+        fmt.write_str(": ")?;
+    }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_diagnostics/src/display.rs` around lines 282 - 287, The code
unconditionally emits the ": " separators around the category which causes stray
delimiters when location or category are missing; change the printing flow so
separators are only written when the adjacent component actually produced output
— for example modify print_location(...) and print_category(...) to return a
bool (or provide a helper like wrote_something()) and then wrap fmt.write_str(":
")? calls in if checks (e.g. if print_location(fmt, diagnostic) { if
print_category(fmt, diagnostic) { fmt.write_str(": ")? } } or more simply track
a local wrote_any flag and only write ": " when the previous component returned
true); update calls around print_category(fmt, diagnostic) and any
fmt.write_str(": ")? uses to use this conditional logic.

---

195-197: ⚠️ Potential issue | 🟡 Minor

Gate header spacing on actual file resources.

On Line 195, resource.is_some() is broader than what Line 193 prints. For non-file resources, this leaves a stray leading space.

💡 Proposed fix

-        let has_file = diagnostic.location().resource.is_some();
+        let has_file = matches!(diagnostic.location().resource, Some(Resource::File(_)));
         if has_file {
             fmt.write_str(" ")?;
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_diagnostics/src/display.rs` around lines 195 - 197, The code
currently sets has_file using diagnostic.location().resource.is_some(), which
adds a space for any resource type and causes a stray space for non-file
resources; change the condition to detect actual file resources (e.g., use
diagnostic.location().resource.as_ref().map_or(false, |r| r.is_file()) or match
on Resource::File) so the leading space (the fmt.write_str call) is only emitted
when the resource is a file; update the has_file binding and keep the
fmt.write_str(" ") call tied to that refined check.

crates/biome_diagnostics/src/display.rs (1)

127-144: Minor cosmetic issue: double space for JetBrains terminals in concise mode.

print_concise writes a space after the icon (line 278), then calls print_file_location. The JetBrains branch adds another leading space via " at {name}", resulting in ✖ at path:1:1.

This only affects JetBrains IDE terminal users, but worth a quick fix if you're in there anyway.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_diagnostics/src/display.rs` around lines 127 - 144, The
JetBrains branch in print_file_location/Display code adds a leading space via
format!(" at {name}") which, combined with print_concise's already-added space
after the icon, yields a double space; remove the extra leading space by
changing the JetBrains branch to print "at {name}" (no leading space) or
otherwise emit "at " + name so the caller's spacing remains correct; update the
branch that checks is_jetbrains (the code that currently does
fmt.write_str(&format!(" at {name}"))?) to emit without the leading space.