fix(lsp): handle wrapped settings in didChangeConfiguration by gaauwe · Pull Request #9611 · biomejs/biome

gaauwe · 2026-03-23T20:22:55Z

This fixes a regression in the Biome LSP configuration update path.

When handling workspace/didChangeConfiguration, the server assumed that params.settings always contained the inner Biome settings object. However, some clients send a wrapped payload such as {"biome": {...}}. After #9323, this became user-visible because didChangeConfiguration started reloading workspace settings immediately, causing the misread settings to re-enable capabilities/diagnostics unexpectedly.

This change makes load_extension_settings(Some(settings)) accept both shapes:

the inner settings object directly
a wrapped object containing a top-level biome key

It also adds a regression test covering wrapped Biome settings sent through didChangeConfiguration.

Related issue

Fixed biome-zed#59: require_config_file could be ignored in Zed when the client sent wrapped Biome settings through workspace/didChangeConfiguration.

Validation

Reproduced the issue in Zed with require_config_file.
Verified that the regression becomes observable at d5ee4690bb (#9323).
Added and ran the regression test:
- should_apply_wrapped_biome_settings_from_did_change_configuration

AI disclosure

I used AI assistance to help investigate the regression, narrow down the introducing commit, and draft the fix/test.

changeset-bot · 2026-03-23T20:23:00Z

🦋 Changeset detected

Latest commit: abff7a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-03-23T20:29:12Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 162a14d8-2a5d-4765-b08a-ab48d4ee87b0

📥 Commits

Reviewing files that changed from the base of the PR and between f8deb9c and 85e8891.

📒 Files selected for processing (1)

.changeset/three-candles-tan.md

✅ Files skipped from review due to trivial changes (1)

.changeset/three-candles-tan.md

Walkthrough

This pull request fixes an LSP regression where workspace configuration updates sent via workspace/didChangeConfiguration were incorrectly parsed when the payload was wrapped in a top-level biome key. The fix modifies the settings extraction logic to unwrap the configuration sub-value when present, falling back to the original settings if absent. A new test verifies the corrected behaviour.

Possibly related PRs

fix(core): custom lsp configuration #9049: Changes how the LSP reads extension settings in the same Session::load_extension_settings method, adjusting workspace loading based on user-provided configuration paths.
fix(lsp): load extension settings before configuration on document open #7764: Modifies the same Session::load_extension_settings behaviour in relation to document opening scenarios.
fix(lsp): correctly resolve configurationPath #9323: Updates workspace and extension configuration parsing in the LSP with related session settings handling changes.

Suggested reviewers

ematipico
dyc3

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: fixing LSP handling of wrapped settings in didChangeConfiguration.
Description check	✅ Passed	The description comprehensively explains the regression, the fix, related issues, validation steps, and AI disclosure—all directly relevant to the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/fix-wrapped-did-change-configuration.md:
- Line 5: Replace the current changeset sentence "Fixed a regression where Biome
LSP could misread editor settings..." so it follows the issue-linked bug-fix
style: begin with "Fixed [`#NUMBER`](issue link): " followed by the user-facing
description (e.g. "Fixed [`#1234`](https://github.com/.../issues/1234): Biome LSP
misread editor settings sent via workspace/didChangeConfiguration when payloads
were wrapped in a top-level `biome` key, causing `requireConfiguration` and
related settings to be ignored."). Also ensure the file ends with a single
trailing newline character.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e187b2e1-3cb5-4a55-b242-337572b80f56

📥 Commits

Reviewing files that changed from the base of the PR and between db67d22 and f8deb9c.

📒 Files selected for processing (3)

.changeset/fix-wrapped-did-change-configuration.md
crates/biome_lsp/src/server.tests.rs
crates/biome_lsp/src/session.rs

coderabbitai · 2026-03-23T20:29:15Z

+"@biomejs/biome": patch
+---
+
+Fixed a regression where Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key. This caused `requireConfiguration` and related settings to be ignored in some editors.


⚠️ Potential issue | 🟡 Minor

Please use the issue-linked bug-fix format and add the final newline.

Line 5 is currently failing markdownlint (MD047), and the sentence should follow the issue-linked changeset style for bug fixes.

✍️ Proposed edit

-Fixed a regression where Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key. This caused `requireConfiguration` and related settings to be ignored in some editors. +Fixed [`#59`](https://github.com/biomejs/biome-zed/issues/59): Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key, causing `requireConfiguration` and related settings to be ignored in some editors. +

As per coding guidelines "Write changeset descriptions for end users, not developers. For bug fixes, start with 'Fixed [#NUMBER](issue link): ...'."
Based on learnings "For BiomeJS changeset markdown entries, use the formatted prefix Fixed [#NUMBER](issue link): ... only when there is a corresponding GitHub issue for the bug."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

Fixed a regression where Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key. This caused `requireConfiguration` and related settings to be ignored in some editors.

Fixed [`#59`](https://github.com/biomejs/biome-zed/issues/59): Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key, causing `requireConfiguration` and related settings to be ignored in some editors.

🧰 Tools

🪛 GitHub Actions: Pull request Markdown

[error] 5-5: markdownlint-cli2 (markdownlint MD047): Files should end with a single newline character.

🪛 GitHub Check: lint

[failure] 5-5: Files should end with a single newline character
.changeset/fix-wrapped-did-change-configuration.md:5:256 MD047/single-trailing-newline Files should end with a single newline character https://github.com/DavidAnson/markdownlint/blob/v0.40.0/doc/md047.md

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In @.changeset/fix-wrapped-did-change-configuration.md at line 5, Replace the current changeset sentence "Fixed a regression where Biome LSP could misread editor settings..." so it follows the issue-linked bug-fix style: begin with "Fixed [`#NUMBER`](issue link): " followed by the user-facing description (e.g. "Fixed [`#1234`](https://github.com/.../issues/1234): Biome LSP misread editor settings sent via workspace/didChangeConfiguration when payloads were wrapped in a top-level `biome` key, causing `requireConfiguration` and related settings to be ignored."). Also ensure the file ends with a single trailing newline character.

fix(lsp): handle wrapped settings in didChangeConfiguration

bc4d118

github-actions Bot added the A-LSP Area: language server protocol label Mar 23, 2026

chore: add changeset for wrapped didChangeConfiguration fix

85e8891

gaauwe force-pushed the fix/zed-did-change-configuration-settings branch from f8deb9c to 85e8891 Compare March 23, 2026 20:28

coderabbitai Bot reviewed Mar 23, 2026

View reviewed changes

[autofix.ci] apply automated fixes

abff7a3

github-actions Bot added the A-Project Area: project label Mar 23, 2026

ematipico approved these changes Mar 24, 2026

View reviewed changes

ematipico merged commit cddaa44 into biomejs:main Mar 24, 2026
13 of 14 checks passed

This was referenced Mar 23, 2026

ci: release #9549

Merged

ci: release #9620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(lsp): handle wrapped settings in didChangeConfiguration#9611

fix(lsp): handle wrapped settings in didChangeConfiguration#9611
ematipico merged 3 commits intobiomejs:mainfrom
gaauwe:fix/zed-did-change-configuration-settings

gaauwe commented Mar 23, 2026

Uh oh!

changeset-bot Bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	Fixed a regression where Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key. This caused `requireConfiguration` and related settings to be ignored in some editors.
	Fixed [`#59`](https://github.com/biomejs/biome-zed/issues/59): Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key, causing `requireConfiguration` and related settings to be ignored in some editors.

Uh oh!

Conversation

gaauwe commented Mar 23, 2026

Related issue

Validation

AI disclosure

Uh oh!

changeset-bot Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Mar 23, 2026 •

edited

Loading

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading