Skip to content

chore(Cargo.toml): clean up, compile insta in opt-level=3#9698

Merged
Conaclos merged 1 commit intomainfrom
conaclos/cleanup-cargo-toml
Mar 29, 2026
Merged

chore(Cargo.toml): clean up, compile insta in opt-level=3#9698
Conaclos merged 1 commit intomainfrom
conaclos/cleanup-cargo-toml

Conversation

@Conaclos
Copy link
Copy Markdown
Member

@Conaclos Conaclos commented Mar 29, 2026 •
edited
Loading

Summary

  • Remove outdated comments
  • Re-enable the Clippy rule mem_forget: we disabled it because of an issue that is now fixed.
  • Compile insta and its similar dependency in optimization level 3 as recommended by insta. This marginally improved the test time on my machine (between 1% and 2%).
  • Remove "allow" lint rules

Test Plan

Everything should stay green.

Docs

Nothing to document.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 29, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9e328b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conaclos Conaclos changed the title chore(Cargo.toml): clean up, always compile insta in opt level 3 chore(Cargo.toml): clean up, compile insta in opt-level=3 Mar 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 29, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 004b34ff-6114-49f0-9eff-3593e41cc33a

📥 Commits

Reviewing files that changed from the base of the PR and between 3c2b36d and 9e328b4.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/biome_service/src/workspace/server.rs
💤 Files with no reviewable changes (1)
  • crates/biome_service/src/workspace/server.rs

Walkthrough

Removed a [workspace.dependencies] entry for anyhow = "1.0.102" and deleted adjacent comment-only markers. Kept resolver = "2" and workspace members unchanged. In [workspace.lints.clippy] added mem_forget = "warn" and removed several lint entries/comments. Added [profile.dev.package.insta] and [profile.dev.package.similar] with opt-level = 3. No public Rust APIs were changed.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarises the main changes: cleanup of Cargo.toml and compilation of insta with opt-level=3.
Description check ✅ Passed The description clearly relates to the changeset, detailing the removal of comments, re-enabling mem_forget, configuring insta compilation, and removing allow lint rules.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch conaclos/cleanup-cargo-toml

Comment @coderabbitai help to get the list of available commands and usage tips.

@Conaclos Conaclos force-pushed the conaclos/cleanup-cargo-toml branch from bb6f5de to 3c2b36d Compare March 29, 2026 17:40
ematipico
ematipico approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's restore the comments. They were useful

Comment thread Cargo.toml
Comment on lines -17 to 26
# Crates needed in the workspace
anyhow = "1.0.102"
# publish
biome_analyze = { path = "./crates/biome_analyze", version = "0.5.7" }
biome_analyze_macros = { path = "./crates/biome_analyze_macros" }
biome_aria = { path = "./crates/biome_aria", version = "0.5.7" }
biome_aria_metadata = { path = "./crates/biome_aria_metadata", version = "0.5.7" }
biome_bench_utils = { path = "./crates/biome_bench_utils" }
# not publish
biome_cli = { path = "./crates/biome_cli" }
Copy link
Copy Markdown
Member

@ematipico ematipico Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments were useful here

Copy link
Copy Markdown
Member Author

@Conaclos Conaclos Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately they are outdated:

  • Crates needed in the workspace doesn't concern only anyhow.
  • We have more than 5 published crates?

It seems that it is hard to keep comments in sync. This is why I removed them. What do you think?

Copy link
Copy Markdown
Member

@ematipico ematipico Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@Conaclos Conaclos force-pushed the conaclos/cleanup-cargo-toml branch from 3c2b36d to 9e328b4 Compare March 29, 2026 17:47
@github-actions github-actions Bot added the A-Project Area: project label Mar 29, 2026
@Conaclos Conaclos merged commit fa561a5 into main Mar 29, 2026
13 checks passed
@Conaclos Conaclos deleted the conaclos/cleanup-cargo-toml branch March 29, 2026 18:15
@coderabbitai coderabbitai Bot mentioned this pull request Apr 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-Project Area: project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Conaclos @ematipico @dyc3