Skip to content

refactor(useConsistentTestIt): review feedback#9827

Merged
dyc3 merged 1 commit intomainfrom
dyc3/useConsistentTestIt
Apr 6, 2026
Merged

refactor(useConsistentTestIt): review feedback#9827
dyc3 merged 1 commit intomainfrom
dyc3/useConsistentTestIt

Conversation

@dyc3
Copy link
Copy Markdown
Contributor

@dyc3 dyc3 commented Apr 6, 2026

Summary

Implemented review feedback.

#9350 (review)

cc @ematipico

Test Plan

green ci

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 6, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3444da9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 6, 2026
ematipico
ematipico approved these changes Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 6, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 34d9846f-125a-43a7-836a-873dfc81b8fc

📥 Commits

Reviewing files that changed from the base of the PR and between 67fca1e and 3444da9.

⛔ Files ignored due to path filters (5)
  • crates/biome_cli/tests/snapshots/main_cases_linter_domains/should_enable_domain_via_cli.snap is excluded by !**/*.snap and included by **
  • crates/biome_js_analyze/tests/specs/nursery/useConsistentTestIt/invalid.js.snap is excluded by !**/*.snap and included by **
  • crates/biome_js_analyze/tests/specs/nursery/useConsistentTestIt/invalidCommentTrivia.js.snap is excluded by !**/*.snap and included by **
  • crates/biome_js_analyze/tests/specs/nursery/useConsistentTestIt/invalidFnTest.js.snap is excluded by !**/*.snap and included by **
  • crates/biome_js_analyze/tests/specs/nursery/useConsistentTestIt/invalidWithinDescribeTest.js.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (1)
  • crates/biome_js_analyze/src/lint/nursery/use_consistent_test_it.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/biome_js_analyze/src/lint/nursery/use_consistent_test_it.rs

Walkthrough

The use_consistent_test_it lint rule was reorganised: the TestFunctionName enum and its as_str/from_str helpers were moved from before the declare_lint_rule! block to after the impl Rule for UseConsistentTestIt block. Diagnostic text was updated: the error now states the test function is inconsistent with the configured preferred function, and the note now explains that consistent test function usage improves readability and searchability. No public APIs were changed.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: a refactor of the useConsistentTestIt rule implementing review feedback, which matches the enum reordering and message updates in the changeset.
Description check ✅ Passed The description is related to the changeset, referencing specific review feedback and linking to the prior discussion that motivated these changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dyc3/useConsistentTestIt

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 6, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks1

Comparing dyc3/useConsistentTestIt (3444da9) with main (f3d60a6)2

Open in CodSpeed

Footnotes

  1. 196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (d5ca672) during the generation of this report, so f3d60a6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@dyc3 dyc3 force-pushed the dyc3/useConsistentTestIt branch from 67fca1e to 3444da9 Compare April 6, 2026 12:29
@github-actions github-actions Bot added the A-CLI Area: CLI label Apr 6, 2026
@dyc3 dyc3 merged commit 82b9c4a into main Apr 6, 2026
17 checks passed
@dyc3 dyc3 deleted the dyc3/useConsistentTestIt branch April 6, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyc3 @ematipico