fix(migrate): update some more rule metadata by dyc3 · Pull Request #9888 · biomejs/biome

dyc3 · 2026-04-09T17:33:18Z

Summary

A small PR to update the migrate metadata for some rules.

I made the decisions, gpt 5.4 made the edits.

Test Plan

green ci

Docs

changeset-bot · 2026-04-09T17:33:23Z

🦋 Changeset detected

Latest commit: b4a242b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-04-09T17:38:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49088f49-7703-44e5-9fae-c9c022fde1bc

📥 Commits

Reviewing files that changed from the base of the PR and between bdcda13 and b4a242b.

⛔ Files ignored due to path filters (1)

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **

📒 Files selected for processing (1)

.changeset/many-snakes-wonder.md

✅ Files skipped from review due to trivial changes (1)

.changeset/many-snakes-wonder.md

Walkthrough

Adds a Changesets entry for @biomejs/biome (patch) clarifying that biome migrate eslint categorises ESLint rules as redundant, unsupported, or unimplemented. Reclassifies several Vue.js ESLint rules between Stylistic and FormatterCovers in the unsupported-rules mapping. Updates the useBaseline CSS lint rule to include HtmlEslint("use-baseline").inspired() alongside the existing EslintCss source. No runtime or public API signatures were changed.

Suggested labels

A-CLI, A-Linter, L-CSS, L-HTML

Suggested reviewers

ematipico

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references the main change: updating rule metadata for the migrate functionality, which aligns with the actual changes across three files.
Description check	✅ Passed	The description adequately relates to the changeset, explaining the motivation to update migrate metadata for rules and disclosing AI assistance in the editing process.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch dyc3/rule-migrate-metadata

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

crates/biome_cli/src/execute/migrate/unsupported_rules.rs (1)
271-301: ⚠️ Potential issue | 🟡 Minor

Add explicit test assertion for reclassified Vue rules.

The unsupported_rule_reason() function does exercise these rules through binary search at runtime, but there's no explicit unit test assertion for the five reclassified Vue rules (lines 271–301). The existing test sanity_check_unsupported_rule_lookup() validates only eol-last. Per project guidelines, classifications affecting user-facing migrate output should have explicit test coverage—consider adding assertions for at least brace-style, comma-dangle, max-attributes-per-line, multiline-html-element-content-newline, and mustache-interpolation-spacing to the test, matching the pattern already established.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@crates/biome_cli/src/execute/migrate/unsupported_rules.rs` around lines 271 -
301, The test sanity_check_unsupported_rule_lookup() only asserts eol-last but
lacks explicit assertions for the five reclassified Vue rules; add assertions
that call unsupported_rule_reason(...) (or use the same helper pattern in that
test) for EslintVueJs("brace-style"), EslintVueJs("comma-dangle"),
EslintVueJs("max-attributes-per-line"),
EslintVueJs("multiline-html-element-content-newline"), and
EslintVueJs("mustache-interpolation-spacing") and assert their returned
UnsupportedRuleReason matches the expected classifications (FormatterCovers,
FormatterCovers, Stylistic, FormatterCovers, FormatterCovers respectively)
following the existing assertion style in
sanity_check_unsupported_rule_lookup().

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/many-snakes-wonder.md:
- Line 5: Replace the incorrect phrase "better reflects" with "better reflect"
in the changeset text so the sentence reads "...to better reflect which ESLint
rules are redundant versus unsupported versus unimplemented."; locate the exact
occurrence of the string "better reflects" in the changeset content and update
it to "better reflect" to fix the grammar.

---

Outside diff comments:
In `@crates/biome_cli/src/execute/migrate/unsupported_rules.rs`:
- Around line 271-301: The test sanity_check_unsupported_rule_lookup() only
asserts eol-last but lacks explicit assertions for the five reclassified Vue
rules; add assertions that call unsupported_rule_reason(...) (or use the same
helper pattern in that test) for EslintVueJs("brace-style"),
EslintVueJs("comma-dangle"), EslintVueJs("max-attributes-per-line"),
EslintVueJs("multiline-html-element-content-newline"), and
EslintVueJs("mustache-interpolation-spacing") and assert their returned
UnsupportedRuleReason matches the expected classifications (FormatterCovers,
FormatterCovers, Stylistic, FormatterCovers, FormatterCovers respectively)
following the existing assertion style in
sanity_check_unsupported_rule_lookup().

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23c85c89-4caa-4f0f-8153-17bb3b7b3596

📥 Commits

Reviewing files that changed from the base of the PR and between a2933bf and bdcda13.

📒 Files selected for processing (3)

.changeset/many-snakes-wonder.md
crates/biome_cli/src/execute/migrate/unsupported_rules.rs
crates/biome_css_analyze/src/lint/nursery/use_baseline.rs

codspeed-hq · 2026-04-09T17:43:09Z

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 227 skipped benchmarks¹

_{Comparing dyc3/rule-migrate-metadata (b4a242b) with main (e8cad58)}

227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

fix(migrate): update some more rule metadata

bdcda13

github-actions Bot added A-CLI Area: CLI A-Linter Area: linter L-CSS Language: CSS and super languages labels Apr 9, 2026

coderabbitai Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread .changeset/many-snakes-wonder.md Outdated

[autofix.ci] apply automated fixes

82fd180

Update .changeset/many-snakes-wonder.md

b4a242b

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

ematipico approved these changes Apr 9, 2026

View reviewed changes

dyc3 merged commit 362b638 into main Apr 9, 2026
19 checks passed

dyc3 deleted the dyc3/rule-migrate-metadata branch April 9, 2026 18:13

github-actions Bot mentioned this pull request Apr 9, 2026

ci: release #9890

Merged

This was referenced Apr 14, 2026

perf(noMagicNumbers): reduce allocations #9982

Merged

chore: extra @eslint/css rule sources #10063

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(migrate): update some more rule metadata#9888

fix(migrate): update some more rule metadata#9888
dyc3 merged 3 commits intomainfrom
dyc3/rule-migrate-metadata

dyc3 commented Apr 9, 2026

Uh oh!

changeset-bot Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dyc3 commented Apr 9, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Apr 9, 2026 •

edited

Loading

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 9, 2026 •

edited

Loading