Conversation
🦋 Changeset detectedLatest commit: 3e97fcd The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds two new RuleSource variants: Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.changeset/violet-turtles-smile.md (1)
5-5: Clarify the user-facing impact in the changeset text.This reads a bit vague (“react-xyz”, “a bit better”). Please name the affected sources explicitly and state the behaviour change directly.
✍️ Suggested wording
-Added extra rule sources from react-xyz. `biome migrate eslint` should do a bit better detecting rules in your eslint configurations. +Added support for additional ESLint React rule sources, including `react-jsx` and `react-dom`. `biome migrate eslint` now detects and migrates more React plugin rules from ESLint configurations.As per coding guidelines: “Write changeset descriptions concisely and clearly (1-3 sentences) …”.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.changeset/violet-turtles-smile.md at line 5, Update the changeset text that currently reads "Added extra rule sources from react-xyz. `biome migrate eslint` should do a bit better detecting rules in your eslint configurations." to a concise 1–3 sentence description that explicitly lists the added rule sources (replace "react-xyz" with the actual package/rule names added) and clearly states the user-facing behavior change (for example: "`biome migrate eslint` now recognizes and maps rules from <list-of-sources>, improving detection and migration of those rules in ESLint configs"). Ensure the new text names the affected sources and describes the exact improvement to rule detection/mapping.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs`:
- Around line 417-418: Add end-to-end tests that cover the new mapping cases for
"react-jsx" and "react-dom": create test fixtures that simulate an ESLint config
containing rules/plugins referencing "react-jsx" and "react-dom", invoke the
ESLint-to-Biome migration logic (the code paths that resolve to
RuleSource::EslintReactJsx and RuleSource::EslintReactDom in
migrate::eslint_to_biome), and assert the migrated output includes the expected
RuleSource resolution and resulting Biome rules (use snapshot assertions or
precise asserts depending on existing test style). Place these tests alongside
the other migration specs in the migrate tests module, name them clearly (e.g.,
migrate_react_jsx_plugin_and_react_dom_plugin), and ensure they fail before the
fix and pass after to provide full coverage for the added mappings.
In
`@crates/biome_js_analyze/src/lint/correctness/no_void_elements_with_children.rs`:
- Line 38: The issue is that using RuleSource::EslintReactDom with the rule name
"dom-no-void-elements-with-children" causes to_rule_url to prepend another
"dom-" resulting in "dom-dom-no-void-elements-with-children"; fix by replacing
the second source variant
RuleSource::EslintReactDom("dom-no-void-elements-with-children") with the
non-prefixed variant RuleSource::EslintReactXyz (or RuleSource::EslintReact with
the correct rule name) and pass the rule name without the "dom-" prefix so the
generated URL becomes correct; update the sources array where
RuleSource::EslintReactDom is referenced to use the appropriate
EslintReactXyz/EslintReact variant and remove the duplicated "dom-" in the rule
string.
---
Nitpick comments:
In @.changeset/violet-turtles-smile.md:
- Line 5: Update the changeset text that currently reads "Added extra rule
sources from react-xyz. `biome migrate eslint` should do a bit better detecting
rules in your eslint configurations." to a concise 1–3 sentence description that
explicitly lists the added rule sources (replace "react-xyz" with the actual
package/rule names added) and clearly states the user-facing behavior change
(for example: "`biome migrate eslint` now recognizes and maps rules from
<list-of-sources>, improving detection and migration of those rules in ESLint
configs"). Ensure the new text names the affected sources and describes the
exact improvement to rule detection/mapping.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4c59d8ce-f4bc-477f-b9e4-b171fda44af4
📒 Files selected for processing (16)
.changeset/violet-turtles-smile.mdcrates/biome_analyze/src/rule.rscrates/biome_cli/src/execute/migrate/eslint_to_biome.rscrates/biome_html_analyze/src/lint/nursery/no_script_url.rscrates/biome_js_analyze/src/lint/a11y/use_button_type.rscrates/biome_js_analyze/src/lint/complexity/no_useless_fragments.rscrates/biome_js_analyze/src/lint/correctness/no_children_prop.rscrates/biome_js_analyze/src/lint/correctness/no_nested_component_definitions.rscrates/biome_js_analyze/src/lint/correctness/no_void_elements_with_children.rscrates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rscrates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rscrates/biome_js_analyze/src/lint/nursery/no_script_url.rscrates/biome_js_analyze/src/lint/security/no_blank_target.rscrates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html.rscrates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html_with_children.rscrates/biome_js_analyze/src/lint/suspicious/no_array_index_key.rs
Comment on lines
+417
to
+418
| Some("react-jsx") => RuleSource::EslintReactJsx, | ||
| Some("react-dom") => RuleSource::EslintReactDom, |
Contributor
There was a problem hiding this comment.
Add migration tests for the new react-jsx/react-dom mappings.
Line [417] and Line [418] introduce new rule-source resolution paths, but there’s no accompanying spec/snapshot coverage proving these keys migrate correctly. Please add fixtures that exercise both plugin names end-to-end.
As per coding guidelines: “All code changes MUST include appropriate tests … and bug fixes require tests that reproduce and validate the fix.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs` around lines 417 -
418, Add end-to-end tests that cover the new mapping cases for "react-jsx" and
"react-dom": create test fixtures that simulate an ESLint config containing
rules/plugins referencing "react-jsx" and "react-dom", invoke the
ESLint-to-Biome migration logic (the code paths that resolve to
RuleSource::EslintReactJsx and RuleSource::EslintReactDom in
migrate::eslint_to_biome), and assert the migrated output includes the expected
RuleSource resolution and resulting Biome rules (use snapshot assertions or
precise asserts depending on existing test style). Place these tests alongside
the other migration specs in the migrate tests module, name them clearly (e.g.,
migrate_react_jsx_plugin_and_react_dom_plugin), and ensure they fail before the
fix and pass after to provide full coverage for the added mappings.
Member
There was a problem hiding this comment.
@coderabbitai we usually don't this because everything is code generated
Contributor
There was a problem hiding this comment.
@ematipico got it — since the rule source resolution and migration mappings are all code-generated, manual snapshot tests for these new plugin name entries aren't necessary. I'll update my understanding accordingly.
✏️ Learnings added
Learnt from: ematipico
Repo: biomejs/biome PR: 9895
File: crates/biome_cli/src/execute/migrate/eslint_to_biome.rs:417-418
Timestamp: 2026-04-10T06:06:26.184Z
Learning: In biomejs/biome, new plugin name → RuleSource mappings added to the `TryFrom<&EslintRuleName> for RuleSource` impl in `crates/biome_cli/src/execute/migrate/eslint_to_biome.rs` do not require manual snapshot/migration tests because the entire rule source detection and migration pipeline is code-generated. This applies to additions like `Some("react-jsx") => RuleSource::EslintReactJsx` and `Some("react-dom") => RuleSource::EslintReactDom`.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: ematipico
Repo: biomejs/biome PR: 9895
File: crates/biome_analyze/src/rule.rs:157-160
Timestamp: 2026-04-10T06:05:01.625Z
Learning: In biomejs/biome, `RuleSource` enum variants in `crates/biome_analyze/src/rule.rs` (e.g., `EslintReactJsx`, `EslintReactDom`) are pure metadata that only affect codegen and `biome migrate eslint` detection. Adding new variants does not require snapshot tests, as there is no behavioral rule logic to validate.
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `RuleSource::Eslint("rule-name").inspired()` when porting an ESLint rule with different behavior or options
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `RuleSource::Eslint("rule-name").same()` when porting an ESLint rule with matching behavior
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_js_analyze/lib/src/lint/**/*.rs : Rule language field in `declare_lint_rule!` must be set to `js` for JavaScript, or `jsx`, `ts`, `tsx` for specific dialects
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_js_analyze/lib/src/lint/**/*.rs : Rule naming: Use `use<Framework>...` prefix for rules that overwhelmingly apply to a specific framework (e.g., `noVueReservedProps`)
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Implement `action` function to provide code actions if the rule can suggest fixes or refactorings
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_js_analyze/lib/src/lint/**/*.rs : Rule naming: Use `useShorthand<Concept>` for syntax that can be rewritten using compact syntax (e.g., `useShorthandAssign`)
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `.ok()?` to convert `Result` to `Option` in rule code that returns `Option`
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_js_analyze/lib/src/lint/**/*.rs : Rule naming: Mandate a concept using `use<Concept>` prefix (e.g., `useValidLang`)
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `Semantic<>` query type for rules requiring semantic information like variable references and bindings
Learnt from: CR
Repo: biomejs/biome PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-23T19:15:52.743Z
Learning: Applies to **/*.{rs,ts,tsx,js} : All code changes MUST include appropriate tests: lint rules require snapshot tests in 'tests/specs/{group}/{rule}/', formatters require snapshot tests with valid/invalid cases, parsers require test files covering valid and error cases, and bug fixes require tests that reproduce and validate the fix.
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/tests/specs/*/valid*.{js,ts,tsx,jsx,css,json,graphql} : Create test files with names prefixed `valid` containing code that does not violate the rule
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/tests/specs/*/invalid*.{js,ts,tsx,jsx,css,json,graphql} : Create test files with names prefixed `invalid` containing code that violates the rule
Learnt from: dyc3
Repo: biomejs/biome PR: 8291
File: crates/biome_html_formatter/tests/specs/prettier/vue/html-vue/elastic-header.html:10-10
Timestamp: 2025-12-04T13:29:49.287Z
Learning: Files under `crates/biome_html_formatter/tests/specs/prettier` are test fixtures synced from Prettier and should not receive detailed code quality reviews (e.g., HTTP vs HTTPS, formatting suggestions, etc.). These files are test data meant to validate formatter behavior and should be preserved as-is.
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Add `fix_kind: FixKind::Safe` to `declare_lint_rule!` when code actions always result in code that doesn't change behavior
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Add `fix_kind: FixKind::Unsafe` to `declare_lint_rule!` when code actions may change program behavior
Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2026-04-06T21:31:01.863Z
Learning: Provide pull requests to the `next` branch for promoting rules from nursery and for implementing new features that affect end users
Learnt from: dyc3
Repo: biomejs/biome PR: 8901
File: crates/biome_analyze_macros/src/group_macro.rs:9-9
Timestamp: 2026-01-29T22:10:30.888Z
Learning: Do not import xtask inside biome crates. In the biomeps repository, ensure that biome crates (e.g., crates/biome_*/...) do not have imports like use xtask_glue::... or other xtask-related crates. The correct dependency direction is for xtask to depend on and import biome crates, not the reverse, since xtask contains heavier utilities (e.g., git2) that can inflate build times when included in biome crates. When reviewing, verify dependency declarations (Cargo.toml) and any use statements to confirm xtask crates are not pulled into biome crates; prefer having xtask depend on biome crates and export needed functionality through stable interfaces.
Learnt from: jfmcdowell
Repo: biomejs/biome PR: 9783
File: crates/biome_markdown_parser/src/syntax/inline/html.rs:261-269
Timestamp: 2026-04-03T17:11:44.346Z
Learning: In the biomejs/biome codebase, when handling whitespace and character classification, use the whitespace/character classification dispatch tables from `biome_unicode_table::lookup_byte` (e.g., `Dispatch::WHS`) rather than ad-hoc raw byte literal comparisons (e.g., `b <= b' '` or explicit `b == b'\t'`). When reviewing this repo, do not treat `biome_unicode_table` dispatch variants as a spec-alignment issue—dispatch-table usage is the requested/accepted approach.
634b2b1 to
e72d94f
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@crates/biome_analyze/src/rule.rs`:
- Around line 157-160: Add snapshot regression tests that assert the
name-spacing and URL generation for the new enum variants EslintReactJsx and
EslintReactDom: create focused tests that construct rules using these variants
and verify the mapped namespace string and generated URL are exactly as expected
(cover both variants and any expected formatting differences). Place tests
alongside other rule mapping specs following the project's test conventions for
rule mappings/snapshots, include both positive assertions and a snapshot of the
resulting mapping output, and mirror the same coverage added for the other
variants referenced (lines showing similar variants) so future mapping drift is
caught.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fe782a59-f80c-4b38-a560-360a1c7a9883
⛔ Files ignored due to path filters (1)
crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rsis excluded by!**/migrate/eslint_any_rule_to_biome.rsand included by**
📒 Files selected for processing (16)
.changeset/violet-turtles-smile.mdcrates/biome_analyze/src/rule.rscrates/biome_cli/src/execute/migrate/eslint_to_biome.rscrates/biome_html_analyze/src/lint/nursery/no_script_url.rscrates/biome_js_analyze/src/lint/a11y/use_button_type.rscrates/biome_js_analyze/src/lint/complexity/no_useless_fragments.rscrates/biome_js_analyze/src/lint/correctness/no_children_prop.rscrates/biome_js_analyze/src/lint/correctness/no_nested_component_definitions.rscrates/biome_js_analyze/src/lint/correctness/no_void_elements_with_children.rscrates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rscrates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rscrates/biome_js_analyze/src/lint/nursery/no_script_url.rscrates/biome_js_analyze/src/lint/security/no_blank_target.rscrates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html.rscrates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html_with_children.rscrates/biome_js_analyze/src/lint/suspicious/no_array_index_key.rs
✅ Files skipped from review due to trivial changes (9)
- .changeset/violet-turtles-smile.md
- crates/biome_js_analyze/src/lint/correctness/no_nested_component_definitions.rs
- crates/biome_html_analyze/src/lint/nursery/no_script_url.rs
- crates/biome_js_analyze/src/lint/nursery/no_script_url.rs
- crates/biome_js_analyze/src/lint/a11y/use_button_type.rs
- crates/biome_js_analyze/src/lint/correctness/no_children_prop.rs
- crates/biome_js_analyze/src/lint/complexity/no_useless_fragments.rs
- crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs
- crates/biome_js_analyze/src/lint/security/no_blank_target.rs
🚧 Files skipped from review as they are similar to previous changes (6)
- crates/biome_cli/src/execute/migrate/eslint_to_biome.rs
- crates/biome_js_analyze/src/lint/suspicious/no_array_index_key.rs
- crates/biome_js_analyze/src/lint/correctness/use_exhaustive_dependencies.rs
- crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html.rs
- crates/biome_js_analyze/src/lint/correctness/no_void_elements_with_children.rs
- crates/biome_js_analyze/src/lint/security/no_dangerously_set_inner_html_with_children.rs
Comment on lines
+157
to
+160
| /// Rules from [eslint-react.xyz](https://eslint-react.xyz/) | ||
| EslintReactJsx(&'a str), | ||
| /// Rules from [eslint-react.xyz](https://eslint-react.xyz/) | ||
| EslintReactDom(&'a str), |
Contributor
There was a problem hiding this comment.
Please add regression tests for the new source variants.
This change adds new externally visible mapping behaviour, but there’s no test coverage shown for EslintReactJsx/EslintReactDom name-spacing and URL generation. A small focused test here would prevent silent mapping drift later.
As per coding guidelines: **/*.{rs,ts,tsx,js}: “All code changes MUST include appropriate tests: lint rules require snapshot tests in 'tests/specs/{group}/{rule}/', formatters require snapshot tests with valid/invalid cases, parsers require test files covering valid and error cases, and bug fixes require tests that reproduce and validate the fix.”
Also applies to: 237-238, 319-320, 373-374, 435-436
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@crates/biome_analyze/src/rule.rs` around lines 157 - 160, Add snapshot
regression tests that assert the name-spacing and URL generation for the new
enum variants EslintReactJsx and EslintReactDom: create focused tests that
construct rules using these variants and verify the mapped namespace string and
generated URL are exactly as expected (cover both variants and any expected
formatting differences). Place tests alongside other rule mapping specs
following the project's test conventions for rule mappings/snapshots, include
both positive assertions and a snapshot of the resulting mapping output, and
mirror the same coverage added for the other variants referenced (lines showing
similar variants) so future mapping drift is caught.
Member
There was a problem hiding this comment.
@coderabbitai this an exception. These are pure metadata that only affect codegen
Contributor
There was a problem hiding this comment.
@ematipico, understood! Since RuleSource enum variants are pure metadata used exclusively for codegen and ESLint migration mapping — with no behavioral rule logic — the snapshot test requirement doesn't apply here. I'll note this for future reviews.
✏️ Learnings added
Learnt from: ematipico
Repo: biomejs/biome PR: 9895
File: crates/biome_analyze/src/rule.rs:157-160
Timestamp: 2026-04-10T06:05:01.625Z
Learning: In biomejs/biome, `RuleSource` enum variants in `crates/biome_analyze/src/rule.rs` (e.g., `EslintReactJsx`, `EslintReactDom`) are pure metadata that only affect codegen and `biome migrate eslint` detection. Adding new variants does not require snapshot tests, as there is no behavioral rule logic to validate.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `RuleSource::Eslint("rule-name").inspired()` when porting an ESLint rule with different behavior or options
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `RuleSource::Eslint("rule-name").same()` when porting an ESLint rule with matching behavior
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_js_analyze/lib/src/lint/**/*.rs : Rule language field in `declare_lint_rule!` must be set to `js` for JavaScript, or `jsx`, `ts`, `tsx` for specific dialects
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_js_analyze/lib/src/lint/**/*.rs : Rule naming: Use `use<Framework>...` prefix for rules that overwhelmingly apply to a specific framework (e.g., `noVueReservedProps`)
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Implement the `Rule` trait with required associated types: `Query`, `State`, `Signals`, and `Options`
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Implement `action` function to provide code actions if the rule can suggest fixes or refactorings
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `Semantic<>` query type for rules requiring semantic information like variable references and bindings
Learnt from: dyc3
Repo: biomejs/biome PR: 8960
File: crates/biome_js_analyze/src/lint/nursery/use_playwright_valid_describe_callback.rs:74-74
Timestamp: 2026-02-05T23:24:11.386Z
Learning: In Rust rule files under crates/biome_analyze/**/*.rs, ensure all helper functions, structs, and enums appear below the impl Rule block, with the only exception being node union declarations used in the rule's Query type, which may stay above the rule block for readability. This guideline applies to files within that specific path; for files outside crates/biome_analyze (e.g., crates/biome_js_analyze/... ), apply the same rule if they belong to a similar analyze crate or review context.
Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2026-04-06T21:31:01.863Z
Learning: Applies to crates/biome_analyze/**/*.rs : Follow technical guidelines and patterns documented in the biome_analyze CONTRIBUTING.md for creating analyzer rules and lint rules
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `.ok()?` to convert `Result` to `Option` in rule code that returns `Option`
Learnt from: CR
Repo: biomejs/biome PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-23T19:15:52.743Z
Learning: Applies to **/*.{rs,ts,tsx,js} : All code changes MUST include appropriate tests: lint rules require snapshot tests in 'tests/specs/{group}/{rule}/', formatters require snapshot tests with valid/invalid cases, parsers require test files covering valid and error cases, and bug fixes require tests that reproduce and validate the fix.
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/tests/specs/*/valid*.{js,ts,tsx,jsx,css,json,graphql} : Create test files with names prefixed `valid` containing code that does not violate the rule
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/tests/specs/*/invalid*.{js,ts,tsx,jsx,css,json,graphql} : Create test files with names prefixed `invalid` containing code that violates the rule
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Add `fix_kind: FixKind::Unsafe` to `declare_lint_rule!` when code actions may change program behavior
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Add `fix_kind: FixKind::Safe` to `declare_lint_rule!` when code actions always result in code that doesn't change behavior
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Use `issue_number` in the rule macro to add a footnote linking to an open GitHub issue for work-in-progress rules
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-04-07T12:58:59.356Z
Learning: Applies to crates/biome_analyze/**/biome_*_analyze/lib/src/lint/**/*.rs : Set rule severity to `Severity::Information` for stylistic suggestions
Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2026-04-06T21:31:01.863Z
Learning: Provide pull requests to the `next` branch for promoting rules from nursery and for implementing new features that affect end users
Learnt from: dyc3
Repo: biomejs/biome PR: 8901
File: crates/biome_analyze_macros/src/group_macro.rs:9-9
Timestamp: 2026-01-29T22:10:30.888Z
Learning: Do not import xtask inside biome crates. In the biomeps repository, ensure that biome crates (e.g., crates/biome_*/...) do not have imports like use xtask_glue::... or other xtask-related crates. The correct dependency direction is for xtask to depend on and import biome crates, not the reverse, since xtask contains heavier utilities (e.g., git2) that can inflate build times when included in biome crates. When reviewing, verify dependency declarations (Cargo.toml) and any use statements to confirm xtask crates are not pulled into biome crates; prefer having xtask depend on biome crates and export needed functionality through stable interfaces.
Learnt from: jfmcdowell
Repo: biomejs/biome PR: 9783
File: crates/biome_markdown_parser/src/syntax/inline/html.rs:261-269
Timestamp: 2026-04-03T17:11:44.346Z
Learning: In the biomejs/biome codebase, when handling whitespace and character classification, use the whitespace/character classification dispatch tables from `biome_unicode_table::lookup_byte` (e.g., `Dispatch::WHS`) rather than ad-hoc raw byte literal comparisons (e.g., `b <= b' '` or explicit `b == b'\t'`). When reviewing this repo, do not treat `biome_unicode_table` dispatch variants as a spec-alignment issue—dispatch-table usage is the requested/accepted approach.
dyc3
reviewed
Apr 9, 2026
Comment on lines
+157
to
+160
| /// Rules from [eslint-react.xyz](https://eslint-react.xyz/) | ||
| EslintReactJsx(&'a str), | ||
| /// Rules from [eslint-react.xyz](https://eslint-react.xyz/) | ||
| EslintReactDom(&'a str), |
Contributor
There was a problem hiding this comment.
after looking at it more closely, I see why you did this. the upstream is somewhat annoyingly organized.
that being said, these comments need to explain how they are different from the base EslintReactXyz
Member
Author
There was a problem hiding this comment.
Yeah they basically have the category plugins and an overarching plugin that contains all the rules from all categories
ematipico
approved these changes
Apr 10, 2026
dyc3
approved these changes
Apr 10, 2026
Merged
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Event more rule sources
Test Plan
Docs