crates/biome_js_analyze/src/lint/nursery/no_component_hook_factories.rs (1)

230-272: Consider extending test mock detection for additional frameworks.

The current implementation supports vi.mock and jest.mock. You might want to consider whether other common patterns like sinon.stub, td.replace (testdouble), or Bun's mock.module would benefit from similar treatment. Not blocking, as the current coverage handles the most common cases.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_js_analyze/src/lint/nursery/no_component_hook_factories.rs`
around lines 230 - 272, is_inside_test_mock_callback currently only recognizes
calls where the member name token equals "mock" and the object identifier equals
"vi" or "jest"; extend its detection to include other common test utilities by
matching additional object+method combinations (e.g., object "sinon" with method
"stub", object "td" with method "replace", and Bun's "mock" module such as
object "mock" with method "module" or similar). Update the checks around
method_token.text_trimmed() and object_token.text_trimmed() inside
is_inside_test_mock_callback to accept those extra pairs (or a small whitelist
map of allowed object→method names) so the function returns true for those
frameworks as well while preserving existing early-returns and structure.

crates/biome_js_analyze/src/lint/nursery/no_component_hook_factories.rs (2)

239-259: Minor semantic inconsistency in return type usage.

is_test_mock_call returns None when the method isn't "mock" (line 248) but returns Some(false) when the object isn't vi/jest (line 258). Both are treated identically by the caller via unwrap_or(false), so no bug here—just a minor readability nit.

♻️ Optional: consistent return semantics

 fn is_test_mock_call(ancestor: &JsSyntaxNode) -> Option<bool> {
     let call_expr = JsCallExpression::cast_ref(ancestor)?;
     let member = call_expr
         .callee()
         .ok()?
         .as_js_static_member_expression()?
         .clone();
     let method_token = member.member().ok()?.as_js_name()?.value_token().ok()?;
     if method_token.text_trimmed() != "mock" {
-        return None;
+        return Some(false);
     }
     let object_token = member
         .object()
         .ok()?
         .as_js_identifier_expression()?
         .name()
         .ok()?
         .value_token()
         .ok()?;
     Some(matches!(object_token.text_trimmed(), "vi" | "jest"))
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_js_analyze/src/lint/nursery/no_component_hook_factories.rs`
around lines 239 - 259, The helper is_test_mock_call has inconsistent semantics:
it returns None when the callee method isn't "mock" but returns Some(false) when
the object isn't "vi"/"jest"; change the early exit in is_test_mock_call (the
branch that currently returns None when method_token.text_trimmed() != "mock")
to return Some(false) so the function consistently returns Some(bool) and
callers can rely on the boolean result without treating None specially.

---

293-299: Heuristic is reasonable but worth documenting.

Checking only the first character catches the common HOC parameter patterns (WrappedComponent, Component), but would also match less conventional names like URL or ID. This is probably fine in practice; a brief comment noting the trade-off could help future readers.

📝 Optional: add clarifying comment

     Some(
+        // PascalCase heuristic: first char uppercase. May match acronyms (URL, ID),
+        // but these are rare as component parameter names.
         name_token
             .text_trimmed()
             .chars()
             .next()
             .is_some_and(char::is_uppercase),
     )

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_js_analyze/src/lint/nursery/no_component_hook_factories.rs`
around lines 293 - 299, The heuristic that checks only the first character of
name_token (the
Some(name_token.text_trimmed().chars().next().is_some_and(char::is_uppercase)
expression) can misclassify all-uppercase identifiers like URL or ID; add a
concise inline comment above this expression explaining the trade-off (we
intentionally only inspect the first character to catch common HOC param names
like WrappedComponent/Component while accepting rare false positives such as
URL/ID) so future readers understand the reasoning and limitations of the
heuristic.

crates/biome_js_analyze/src/lint/nursery/no_component_hook_factories.rs (1)

280-300: Minor: Unnecessary .clone() on line 285.

The binding() method takes &self, so you can call it directly on the reference from as_js_formal_parameter() without cloning.

♻️ Suggested simplification

 fn is_pascal_case_param(param: SyntaxResult<AnyJsParameter>) -> Option<bool> {
-    let formal = param
+    let name_token = param
         .ok()?
         .as_any_js_formal_parameter()?
-        .as_js_formal_parameter()?
-        .clone();
-    let name_token = formal
+        .as_js_formal_parameter()?
         .binding()
         .ok()?
         .as_any_js_binding()?
         .as_js_identifier_binding()?
         .name_token()
         .ok()?;
     Some(
         name_token
             .text_trimmed()
             .chars()
             .next()
             .is_some_and(char::is_uppercase),
     )
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_js_analyze/src/lint/nursery/no_component_hook_factories.rs`
around lines 280 - 300, The helper function is_pascal_case_param unnecessarily
calls .clone() on the result of as_js_formal_parameter(); remove the .clone()
and call binding() directly on the borrowed formal parameter (i.e., use the
reference returned by as_js_formal_parameter() rather than cloning it). Update
is_pascal_case_param so the chain uses the borrowed value from
as_js_formal_parameter() before calling binding(), preserving the rest of the
unwrap/ok logic (keep names: is_pascal_case_param, as_js_formal_parameter,
binding, name_token).