crates/biome_configuration/src/lib.rs (1)

26-85: Please add or point to a cli feature smoke test.

This introduces a new supported compile surface, but I can’t see matching coverage in the reviewed changes. A quick cargo check for biome_configuration with and without cli would catch stray bpaf imports and attrs before they sneak back in. Happy to help wire that up if useful.

As per coding guidelines **/*.{rs,ts,tsx,js}: All code changes MUST include appropriate tests.

Also applies to: 123-215, 438-439, 576-603

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_configuration/src/lib.rs` around lines 26 - 85, Add a smoke test
that compiles the biome_configuration crate both with and without the "cli"
feature to catch stray bpaf imports and misplaced cfg attributes: create a new
integration test (e.g. tests/cli_feature_smoke.rs) that runs cargo check (or
uses Command to invoke cargo) twice — once with --no-default-features and once
with --features cli — and assert both succeed; ensure this test is part of the
crate's tests so CI runs it, and verify the code paths that reference bpaf,
bpaf::Bpaf, and any cfg(feature = "cli")-guarded items (e.g., the bpaf import
lines and pub use xyz under cfg(feature = "cli")) are correctly gated so the
no-feature build passes.

crates/biome_configuration/src/lib.rs (1)

122-223: Consider adding explicit feature-matrix coverage documentation for biome_configuration.

The crate already gets tested without the cli feature (implicitly, via default = [] in Cargo.toml), so the non-CLI build path is covered by existing tests in tests/spec_tests.rs. However, there's no explicit, documented test target that validates this. Consider adding to justfile or CI:

cargo test -p biome_configuration --no-default-features

This makes it clear for future maintainers that the crate is tested in both configurations.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_configuration/src/lib.rs` around lines 122 - 223, Tests
currently don't explicitly assert the non-CLI build of biome_configuration; add
a CI/justfile job that runs the crate's test suite with no default features to
ensure coverage. Update the project automation (e.g., justfile and CI workflow)
to include a command that runs "cargo test -p biome_configuration
--no-default-features" (or equivalent) and ensure it runs the tests in
tests/spec_tests.rs for the crate; name the job/target clearly (e.g.,
"test:biome_configuration:no-default-features") so maintainers can see the
feature-matrix coverage.