Skip to content

fix(ci): checkout repository before benchmark path filtering on push#9973

Merged
dyc3 merged 1 commit intomainfrom
dyc3/fix-bench-on-push
Apr 13, 2026
Merged

fix(ci): checkout repository before benchmark path filtering on push#9973
dyc3 merged 1 commit intomainfrom
dyc3/fix-bench-on-push

Conversation

@dyc3
Copy link
Copy Markdown
Contributor

@dyc3 dyc3 commented Apr 13, 2026

Summary

fixes the ci job failing on main

Test Plan

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 13, 2026

⚠️ No Changeset found

Latest commit: d62f635

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b42025d3-fb11-4677-8159-08c78d335c8e

📥 Commits

Reviewing files that changed from the base of the PR and between 2cff700 and d62f635.

📒 Files selected for processing (1)
  • .github/workflows/benchmark.yml

Walkthrough

The pull request modifies the benchmark workflow to introduce an explicit checkout step in the changes job that executes exclusively on push events. The step uses actions/[email protected] with fetch-depth: 2 and is positioned before the "Detect benchmark changes" step. No changes to exported or public entities. Six lines added in total.

Possibly related PRs

Suggested reviewers

  • ematipico
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a checkout step before benchmark filtering in the CI workflow for push events.
Description check ✅ Passed The description, though minimal, is related to the changeset—it mentions fixing a CI job failure on main, which aligns with the workflow modification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dyc3/fix-bench-on-push

Comment @coderabbitai help to get the list of available commands and usage tips.

@dyc3 dyc3 merged commit eaa7d3a into main Apr 13, 2026
24 checks passed
@dyc3 dyc3 deleted the dyc3/fix-bench-on-push branch April 13, 2026 22:23
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 13, 2026

Merging this PR will degrade performance by 38.4%

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 246 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ index_d_ts[react/index.d.ts] 31.6 ms 27.5 ms +15.06%
❌ index_d_ts[astro_server.mjs] 116.5 ms 189.1 ms -38.4%
❌ index_d_ts[RedisCommander.d.ts] 134.8 ms 145 ms -7.04%

Comparing dyc3/fix-bench-on-push (d62f635) with main (0a60ce0)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (2cff700) during the generation of this report, so 0a60ce0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dyc3