chore: abstract html tag matcher by Netail · Pull Request #9988 · biomejs/biome

Netail · 2026-04-14T21:30:37Z

Summary

Abstracted checking for regular html tags
Used a smaller union query for certain rules (which affects diagnostic ranges; now only opening & self-closing instead the full open till close, which is better honestly)

Test Plan

Docs

changeset-bot · 2026-04-14T21:30:43Z

🦋 Changeset detected

Latest commit: 6962357

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq · 2026-04-14T21:40:44Z

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 189 skipped benchmarks¹

_{Comparing Netail:chore/rework-is-html-tag (6962357) with main (baaacfc)}

189 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai · 2026-04-15T00:22:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3b1185f7-cc1a-4535-8153-77027b40e539

📥 Commits

Reviewing files that changed from the base of the PR and between a799ccf and 6962357.

📒 Files selected for processing (1)

.changeset/frogs-like-green.md

✅ Files skipped from review due to trivial changes (1)

.changeset/frogs-like-green.md

Walkthrough

This change centralises source-aware HTML tag matching and narrows element types across the analyzer. It adds utils::is_html_tag and AnyHtmlElement::as_any_html_tag_element, moves attribute-lookup helpers onto AnyHtmlTagElement, and updates many lints and a11y helpers to use AnyHtmlTagElement and the new is_html_tag for tag-name checks. Several helper signatures were tightened from &AnyHtmlElement → &AnyHtmlTagElement.

Possibly related PRs

feat(html): port noAriaHiddenOnFocusable a11y rule to HTML #9496 — Narrows a11y helper signatures from AnyHtmlElement to AnyHtmlTagElement, matching the signature changes here.
feat(html/a11y): port noAriaUnsupportedElements to HTML #9491 — Adds as_any_html_tag_element and moves attribute lookup onto tag-level types, touching the same element/attribute APIs.
feat: implement useIframeSandbox #9949 — Refactors iframe-related lints to use AnyHtmlTagElement and is_html_tag, the same pattern applied in this PR.

Suggested reviewers

dyc3
ematipico

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: abstract html tag matcher' accurately reflects the main refactoring objective of consolidating HTML tag matching logic across multiple lint rules.
Description check	✅ Passed	The description clearly relates to the changeset, outlining the core abstraction of HTML tag checking and the resulting diagnostic range improvements from narrower query types.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (2)

crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs (1)

100-109: Consider reusing the cached source_type.

You've already derived source_type at line 83. Lines 100 and 109 call ctx.source_type::<HtmlFileSource>() again—consider using the local variable instead.

♻️ Proposed fix

-        if ctx.source_type::<HtmlFileSource>().is_vue() {
+        if source_type.is_vue() {
             let has_scoped = attributes.find_by_name("scoped").is_some();
             let has_module = attributes.find_by_name("module").is_some();

             if has_scoped || has_module {
                 return None;
             } else {
                 return Some(GlobalStylesKind::Vue);
             }
-        } else if ctx.source_type::<HtmlFileSource>().is_astro() {
+        } else if source_type.is_astro() {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs` around lines
100 - 109, The code calls ctx.source_type::<HtmlFileSource>() multiple times
inside use_scoped_styles.rs (e.g., in the branches that check .is_vue() and
.is_astro()); reuse the previously computed local variable (the cached
source_type you created earlier) instead of calling
ctx.source_type::<HtmlFileSource>() again — replace subsequent
ctx.source_type::<HtmlFileSource>().is_vue()/is_astro() checks with
source_type.is_vue()/source_type.is_astro() to avoid redundant lookups while
preserving the existing conditional logic that returns
Some(GlobalStylesKind::Vue) when no scoped/module attributes are present.

crates/biome_html_analyze/src/lint/nursery/no_script_url.rs (1)

62-73: Consider querying AnyHtmlTagElement directly.

The rule queries HtmlOpeningElement but then converts it to AnyHtmlTagElement for the tag check. This works correctly, though for consistency with other refactored rules in this PR, you could query Ast<AnyHtmlTagElement> directly and avoid the conversion on line 71.

That said, the current approach is functionally correct — self-closing <a/> tags are unusual in practice.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@crates/biome_html_analyze/src/lint/nursery/no_script_url.rs` around lines 62
- 73, Change the rule to query AnyHtmlTagElement directly instead of
HtmlOpeningElement: update the type alias Query from Ast<HtmlOpeningElement> to
Ast<AnyHtmlTagElement>, and in run(ctx: &RuleContext<Self>) use ctx.query() as
an AnyHtmlTagElement (removing the conversion
AnyHtmlTagElement::from(element.clone())). Keep the same source_type check and
is_html_tag call but pass the queried AnyHtmlTagElement directly to is_html_tag;
adjust any variable names/types in run accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@crates/biome_html_analyze/src/lint/nursery/no_script_url.rs`:
- Around line 62-73: Change the rule to query AnyHtmlTagElement directly instead
of HtmlOpeningElement: update the type alias Query from Ast<HtmlOpeningElement>
to Ast<AnyHtmlTagElement>, and in run(ctx: &RuleContext<Self>) use ctx.query()
as an AnyHtmlTagElement (removing the conversion
AnyHtmlTagElement::from(element.clone())). Keep the same source_type check and
is_html_tag call but pass the queried AnyHtmlTagElement directly to is_html_tag;
adjust any variable names/types in run accordingly.

In `@crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs`:
- Around line 100-109: The code calls ctx.source_type::<HtmlFileSource>()
multiple times inside use_scoped_styles.rs (e.g., in the branches that check
.is_vue() and .is_astro()); reuse the previously computed local variable (the
cached source_type you created earlier) instead of calling
ctx.source_type::<HtmlFileSource>() again — replace subsequent
ctx.source_type::<HtmlFileSource>().is_vue()/is_astro() checks with
source_type.is_vue()/source_type.is_astro() to avoid redundant lookups while
preserving the existing conditional logic that returns
Some(GlobalStylesKind::Vue) when no scoped/module attributes are present.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a08b06ee-e62d-42f1-887b-fe5145208da6

📥 Commits

Reviewing files that changed from the base of the PR and between 79c09f2 and 76b0c80.

⛔ Files ignored due to path filters (16)

crates/biome_cli/tests/snapshots/main_cases_handle_astro_files/full_support.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/full_support.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_handle_svelte_files/full_support_ts.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/full_support.snap is excluded by !**/*.snap and included by **
crates/biome_cli/tests/snapshots/main_cases_handle_vue_files/full_support_ts.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useAltText/invalid.html.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useButtonType/invalid.html.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useButtonType/invalid.svelte.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useButtonType/invalid.vue.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useHtmlLang/invalid.html.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useIframeTitle/astro/invalid.astro.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useIframeTitle/invalid.html.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useIframeTitle/svelte/invalid.svelte.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useIframeTitle/vue/invalid.vue.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/a11y/useValidAriaRole/invalid.html.snap is excluded by !**/*.snap and included by **
crates/biome_html_analyze/tests/specs/nursery/useIframeSandbox/invalid.html.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (29)

crates/biome_html_analyze/src/a11y.rs
crates/biome_html_analyze/src/a11y_tests.rs
crates/biome_html_analyze/src/lib.rs
crates/biome_html_analyze/src/lint/a11y/no_autofocus.rs
crates/biome_html_analyze/src/lint/a11y/no_distracting_elements.rs
crates/biome_html_analyze/src/lint/a11y/no_header_scope.rs
crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs
crates/biome_html_analyze/src/lint/a11y/no_redundant_alt.rs
crates/biome_html_analyze/src/lint/a11y/no_svg_without_title.rs
crates/biome_html_analyze/src/lint/a11y/use_alt_text.rs
crates/biome_html_analyze/src/lint/a11y/use_anchor_content.rs
crates/biome_html_analyze/src/lint/a11y/use_aria_props_for_role.rs
crates/biome_html_analyze/src/lint/a11y/use_button_type.rs
crates/biome_html_analyze/src/lint/a11y/use_html_lang.rs
crates/biome_html_analyze/src/lint/a11y/use_iframe_title.rs
crates/biome_html_analyze/src/lint/a11y/use_media_caption.rs
crates/biome_html_analyze/src/lint/a11y/use_valid_aria_role.rs
crates/biome_html_analyze/src/lint/a11y/use_valid_lang.rs
crates/biome_html_analyze/src/lint/nursery/no_ambiguous_anchor_text.rs
crates/biome_html_analyze/src/lint/nursery/no_inline_styles.rs
crates/biome_html_analyze/src/lint/nursery/no_script_url.rs
crates/biome_html_analyze/src/lint/nursery/no_sync_scripts.rs
crates/biome_html_analyze/src/lint/nursery/use_iframe_sandbox.rs
crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs
crates/biome_html_analyze/src/lint/nursery/use_vue_hyphenated_attributes.rs
crates/biome_html_analyze/src/lint/nursery/use_vue_valid_template_root.rs
crates/biome_html_analyze/src/lint/nursery/use_vue_vapor.rs
crates/biome_html_analyze/src/utils.rs
crates/biome_html_syntax/src/element_ext.rs

ematipico

This change affected diagnostics, which are emitted to users. This means that it needs a changeset.

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | patch | `2.4.12` → `2.4.13` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.13`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2413) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/[email protected]...@biomejs/[email protected]) ##### Patch Changes - [#9969](biomejs/biome#9969) [`c5eb92b`](biomejs/biome@c5eb92b) Thanks [@officialasishkumar](https://github.com/officialasishkumar)! - Added the nursery rule [`noUnnecessaryTemplateExpression`](https://biomejs.dev/linter/rules/no-unnecessary-template-expression/), which disallows template literals that only contain string literal expressions. These can be replaced with a simpler string literal. For example, the following code triggers the rule: ```js const a = `${"hello"}`; // can be 'hello' const b = `${"prefix"}_suffix`; // can be 'prefix_suffix' const c = `${"a"}${"b"}`; // can be 'ab' ``` - [#10037](biomejs/biome#10037) [`f785e8c`](biomejs/biome@f785e8c) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) no longer reports false positives on a getter with a matching setter in the same namespace. ```ts class Store { get status(): string { if (Math.random() > 0.5) return "loading"; return "idle"; } set status(v: string) {} } ``` - [#10084](biomejs/biome#10084) [`5e2f90c`](biomejs/biome@5e2f90c) Thanks [@jiwon79](https://github.com/jiwon79)! - Fixed [#10034](biomejs/biome#10034): [`noUselessEscapeInRegex`](https://biomejs.dev/linter/rules/no-useless-escape-in-regex/) no longer flags escapes of `ClassSetReservedPunctuator` characters (`&`, `!`, `#`, `%`, `,`, `:`, `;`, `<`, `=`, `>`, `@`, `` ` ``, `~`) inside `v`-flag character classes as useless. These characters are reserved as individual code points in `v`-mode, so the escape is required. The following pattern is now considered valid: ```js /[a-z\&]/v; ``` - [#10063](biomejs/biome#10063) [`c9ffa16`](biomejs/biome@c9ffa16) Thanks [@Netail](https://github.com/Netail)! - Added extra rule sources from ESLint CSS. `biome migrate eslint` should do a bit better detecting rules in your eslint configurations. - [#10035](biomejs/biome#10035) [`946b50e`](biomejs/biome@946b50e) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10032](biomejs/biome#10032): [useIframeSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox/) now flags if there's no initializer value. - [#9865](biomejs/biome#9865) [`68fb8d4`](biomejs/biome@68fb8d4) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useDomNodeTextContent`](https://biomejs.dev/linter/rules/use-dom-node-text-content/), which prefers `textContent` over `innerText` for DOM node text access and destructuring. For example, the following snippet triggers the rule: ```js const foo = node.innerText; ``` - [#10023](biomejs/biome#10023) [`bd1e74f`](biomejs/biome@bd1e74f) Thanks [@ematipico](https://github.com/ematipico)! - Added a new nursery rule [`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/no-react-native-deep-imports/) that disallows deep imports from the `react-native` package. Internal paths like `react-native/Libraries/...` are not part of the public API and may change between versions. For example, the following code triggers the rule: ```js import View from "react-native/Libraries/Components/View/View"; ``` - [#9885](biomejs/biome#9885) [`3dce737`](biomejs/biome@3dce737) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`useDomQuerySelector`](https://biomejs.dev/linter/rules/use-dom-query-selector/) that prefers `querySelector()` and `querySelectorAll()` over older DOM query methods such as `getElementById()` and `getElementsByClassName()`. - [#9995](biomejs/biome#9995) [`4da9caf`](biomejs/biome@4da9caf) Thanks [@siketyan](https://github.com/siketyan)! - Fixed [#9994](biomejs/biome#9994): Biome now parses nested CSS rules correctly when declarations follow them inside embedded snippets. - [#10009](biomejs/biome#10009) [`b41cc5a`](biomejs/biome@b41cc5a) Thanks [@Jayllyz](https://github.com/Jayllyz)! - Fixed [#10004](biomejs/biome#10004): [`noComponentHookFactories`](https://biomejs.dev/linter/rules/no-component-hook-factories/) no longer reports false positives for object methods and class methods. - [#9988](biomejs/biome#9988) [`eabf54a`](biomejs/biome@eabf54a) Thanks [@Netail](https://github.com/Netail)! - Tweaked the diagnostics range for [useAltText](https://biomejs.dev/linter/rules/use-alt-text), [useButtonType](https://biomejs.dev/linter/rules/use-button-type), [useHtmlLang](https://biomejs.dev/linter/rules/use-html-lang), [useIframeTitle](https://biomejs.dev/linter/rules/use-iframe-title), [useValidAriaRole](https://biomejs.dev/linter/rules/use-valid-aria-role) & [useIfameSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox) to report on the opening tag instead of the full tag. - [#10043](biomejs/biome#10043) [`fc65902`](biomejs/biome@fc65902) Thanks [@mujpao](https://github.com/mujpao)! - Fixed [#10003](biomejs/biome#10003): Biome no longer panics when parsing Svelte files containing `{#}`. - [#9815](biomejs/biome#9815) [`5cc83b1`](biomejs/biome@5cc83b1) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`noLoopFunc`](https://biomejs.dev/linter/rules/no-loop-func/). When enabled, it warns when a function declared inside a loop captures outer variables that can change across iterations. - [#9702](biomejs/biome#9702) [`ef470ba`](biomejs/biome@ef470ba) Thanks [@ryan-m-walker](https://github.com/ryan-m-walker)! - Added the nursery rule [`useRegexpTest`](https://biomejs.dev/linter/rules/use-regexp-test/) that enforces `RegExp.prototype.test()` over `String.prototype.match()` and `RegExp.prototype.exec()` in boolean contexts. `test()` returns a boolean directly, avoiding unnecessary computation of match results. **Invalid** ```js if ("hello world".match(/hello/)) { } ``` **Valid** ```js if (/hello/.test("hello world")) { } ``` - [#9743](biomejs/biome#9743) [`245307d`](biomejs/biome@245307d) Thanks [@leetdavid](https://github.com/leetdavid)! - Fixed [#2245](biomejs/biome#2245): Svelte `<script>` tag language detection when the `generics` attribute contains `>` characters (e.g., `<script lang="ts" generics="T extends Record<string, unknown>">`). Biome now correctly recognizes TypeScript in such script blocks. - [#10046](biomejs/biome#10046) [`0707de7`](biomejs/biome@0707de7) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#10038](biomejs/biome#10038): [`organizeImports`](https://biomejs.dev/assist/actions/organize-imports/) now sorts imports in TypeScript modules and declaration files. ```diff declare module "mymodule" { - import type { B } from "b"; import type { A } from "a"; + import type { B } from "b"; } ``` - [#10012](biomejs/biome#10012) [`94ccca9`](biomejs/biome@94ccca9) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeLiteralColors`](https://biomejs.dev/linter/rules/no-react-native-literal-colors/), which disallows color literals inside React Native styles. The rule belongs to the `reactNative` domain. It reports properties whose name contains `color` and whose value is a string literal when they appear inside a `StyleSheet.create(...)` call or inside a JSX attribute whose name contains `style`. ```jsx // Invalid const Hello = () => <Text style={{ backgroundColor: "#FFFFFF" }}>hi</Text>; const styles = StyleSheet.create({ text: { color: "red" }, }); ``` ```jsx // Valid const red = "#f00"; const styles = StyleSheet.create({ text: { color: red }, }); ``` - [#10005](biomejs/biome#10005) [`131019e`](biomejs/biome@131019e) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeRawText`](https://biomejs.dev/linter/rules/no-react-native-raw-text/), which disallows raw text outside of `<Text>` components in React Native. The rule belongs to the new `reactNative` domain. ```jsx // Invalid <View>some text</View> <View>{'some text'}</View> ``` ```jsx // Valid <View> <Text>some text</Text> </View> ``` Additional components can be allowlisted through the `skip` option: ```json { "options": { "skip": ["Title"] } } ``` - [#9911](biomejs/biome#9911) [`1603f78`](biomejs/biome@1603f78) Thanks [@Netail](https://github.com/Netail)! - Added the nursery rule [`noJsxLeakedDollar`](https://biomejs.dev/linter/rules/no-jsx-leaked-dollar), which flags text nodes with a trailing `$` if the next sibling node is a JSX expression. This could be an unintentional mistake, resulting in a '$' being rendered as text in the output. **Invalid**: ```jsx function MyComponent({ user }) { return <div>Hello ${user.name}</div>; } ``` - [#9999](biomejs/biome#9999) [`f42405f`](biomejs/biome@f42405f) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed `noMisleadingReturnType` incorrectly flagging functions with reassigned `let` variables. - [#10075](biomejs/biome#10075) [`295f97f`](biomejs/biome@295f97f) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [`#9983`](biomejs/biome#9983): Biome now parses functions declared inside Svelte `#snippet` blocks without throwing errors. - [#10006](biomejs/biome#10006) [`cf4c1c9`](biomejs/biome@cf4c1c9) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): `noMisleadingReturnType` incorrectly flagging nested object literals with widened properties. - [#10033](biomejs/biome#10033) [`11ddc05`](biomejs/biome@11ddc05) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`useReactNativePlatformComponents`](https://biomejs.dev/linter/rules/use-react-native-platform-components/) that ensures platform-specific React Native components (e.g. `ProgressBarAndroid`, `ActivityIndicatorIOS`) are only imported in files with a matching platform suffix. It also reports when Android and iOS components are mixed in the same file. The following code triggers the rule when the file does not have an `.android.js` suffix: ```js // file.js import { ProgressBarAndroid } from "react-native"; ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/1

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | patch | `2.4.12` → `2.4.13` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.13`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2413) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/[email protected]...@biomejs/[email protected]) ##### Patch Changes - [#9969](biomejs/biome#9969) [`c5eb92b`](biomejs/biome@c5eb92b) Thanks [@officialasishkumar](https://github.com/officialasishkumar)! - Added the nursery rule [`noUnnecessaryTemplateExpression`](https://biomejs.dev/linter/rules/no-unnecessary-template-expression/), which disallows template literals that only contain string literal expressions. These can be replaced with a simpler string literal. For example, the following code triggers the rule: ```js const a = `${"hello"}`; // can be 'hello' const b = `${"prefix"}_suffix`; // can be 'prefix_suffix' const c = `${"a"}${"b"}`; // can be 'ab' ``` - [#10037](biomejs/biome#10037) [`f785e8c`](biomejs/biome@f785e8c) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) no longer reports false positives on a getter with a matching setter in the same namespace. ```ts class Store { get status(): string { if (Math.random() > 0.5) return "loading"; return "idle"; } set status(v: string) {} } ``` - [#10084](biomejs/biome#10084) [`5e2f90c`](biomejs/biome@5e2f90c) Thanks [@jiwon79](https://github.com/jiwon79)! - Fixed [#10034](biomejs/biome#10034): [`noUselessEscapeInRegex`](https://biomejs.dev/linter/rules/no-useless-escape-in-regex/) no longer flags escapes of `ClassSetReservedPunctuator` characters (`&`, `!`, `#`, `%`, `,`, `:`, `;`, `<`, `=`, `>`, `@`, `` ` ``, `~`) inside `v`-flag character classes as useless. These characters are reserved as individual code points in `v`-mode, so the escape is required. The following pattern is now considered valid: ```js /[a-z\&]/v; ``` - [#10063](biomejs/biome#10063) [`c9ffa16`](biomejs/biome@c9ffa16) Thanks [@Netail](https://github.com/Netail)! - Added extra rule sources from ESLint CSS. `biome migrate eslint` should do a bit better detecting rules in your eslint configurations. - [#10035](biomejs/biome#10035) [`946b50e`](biomejs/biome@946b50e) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10032](biomejs/biome#10032): [useIframeSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox/) now flags if there's no initializer value. - [#9865](biomejs/biome#9865) [`68fb8d4`](biomejs/biome@68fb8d4) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useDomNodeTextContent`](https://biomejs.dev/linter/rules/use-dom-node-text-content/), which prefers `textContent` over `innerText` for DOM node text access and destructuring. For example, the following snippet triggers the rule: ```js const foo = node.innerText; ``` - [#10023](biomejs/biome#10023) [`bd1e74f`](biomejs/biome@bd1e74f) Thanks [@ematipico](https://github.com/ematipico)! - Added a new nursery rule [`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/no-react-native-deep-imports/) that disallows deep imports from the `react-native` package. Internal paths like `react-native/Libraries/...` are not part of the public API and may change between versions. For example, the following code triggers the rule: ```js import View from "react-native/Libraries/Components/View/View"; ``` - [#9885](biomejs/biome#9885) [`3dce737`](biomejs/biome@3dce737) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`useDomQuerySelector`](https://biomejs.dev/linter/rules/use-dom-query-selector/) that prefers `querySelector()` and `querySelectorAll()` over older DOM query methods such as `getElementById()` and `getElementsByClassName()`. - [#9995](biomejs/biome#9995) [`4da9caf`](biomejs/biome@4da9caf) Thanks [@siketyan](https://github.com/siketyan)! - Fixed [#9994](biomejs/biome#9994): Biome now parses nested CSS rules correctly when declarations follow them inside embedded snippets. - [#10009](biomejs/biome#10009) [`b41cc5a`](biomejs/biome@b41cc5a) Thanks [@Jayllyz](https://github.com/Jayllyz)! - Fixed [#10004](biomejs/biome#10004): [`noComponentHookFactories`](https://biomejs.dev/linter/rules/no-component-hook-factories/) no longer reports false positives for object methods and class methods. - [#9988](biomejs/biome#9988) [`eabf54a`](biomejs/biome@eabf54a) Thanks [@Netail](https://github.com/Netail)! - Tweaked the diagnostics range for [useAltText](https://biomejs.dev/linter/rules/use-alt-text), [useButtonType](https://biomejs.dev/linter/rules/use-button-type), [useHtmlLang](https://biomejs.dev/linter/rules/use-html-lang), [useIframeTitle](https://biomejs.dev/linter/rules/use-iframe-title), [useValidAriaRole](https://biomejs.dev/linter/rules/use-valid-aria-role) & [useIfameSandbox](https://biomejs.dev/linter/rules/use-iframe-sandbox) to report on the opening tag instead of the full tag. - [#10043](biomejs/biome#10043) [`fc65902`](biomejs/biome@fc65902) Thanks [@mujpao](https://github.com/mujpao)! - Fixed [#10003](biomejs/biome#10003): Biome no longer panics when parsing Svelte files containing `{#}`. - [#9815](biomejs/biome#9815) [`5cc83b1`](biomejs/biome@5cc83b1) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`noLoopFunc`](https://biomejs.dev/linter/rules/no-loop-func/). When enabled, it warns when a function declared inside a loop captures outer variables that can change across iterations. - [#9702](biomejs/biome#9702) [`ef470ba`](biomejs/biome@ef470ba) Thanks [@ryan-m-walker](https://github.com/ryan-m-walker)! - Added the nursery rule [`useRegexpTest`](https://biomejs.dev/linter/rules/use-regexp-test/) that enforces `RegExp.prototype.test()` over `String.prototype.match()` and `RegExp.prototype.exec()` in boolean contexts. `test()` returns a boolean directly, avoiding unnecessary computation of match results. **Invalid** ```js if ("hello world".match(/hello/)) { } ``` **Valid** ```js if (/hello/.test("hello world")) { } ``` - [#9743](biomejs/biome#9743) [`245307d`](biomejs/biome@245307d) Thanks [@leetdavid](https://github.com/leetdavid)! - Fixed [#2245](biomejs/biome#2245): Svelte `<script>` tag language detection when the `generics` attribute contains `>` characters (e.g., `<script lang="ts" generics="T extends Record<string, unknown>">`). Biome now correctly recognizes TypeScript in such script blocks. - [#10046](biomejs/biome#10046) [`0707de7`](biomejs/biome@0707de7) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#10038](biomejs/biome#10038): [`organizeImports`](https://biomejs.dev/assist/actions/organize-imports/) now sorts imports in TypeScript modules and declaration files. ```diff declare module "mymodule" { - import type { B } from "b"; import type { A } from "a"; + import type { B } from "b"; } ``` - [#10012](biomejs/biome#10012) [`94ccca9`](biomejs/biome@94ccca9) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeLiteralColors`](https://biomejs.dev/linter/rules/no-react-native-literal-colors/), which disallows color literals inside React Native styles. The rule belongs to the `reactNative` domain. It reports properties whose name contains `color` and whose value is a string literal when they appear inside a `StyleSheet.create(...)` call or inside a JSX attribute whose name contains `style`. ```jsx // Invalid const Hello = () => <Text style={{ backgroundColor: "#FFFFFF" }}>hi</Text>; const styles = StyleSheet.create({ text: { color: "red" }, }); ``` ```jsx // Valid const red = "#f00"; const styles = StyleSheet.create({ text: { color: red }, }); ``` - [#10005](biomejs/biome#10005) [`131019e`](biomejs/biome@131019e) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`noReactNativeRawText`](https://biomejs.dev/linter/rules/no-react-native-raw-text/), which disallows raw text outside of `<Text>` components in React Native. The rule belongs to the new `reactNative` domain. ```jsx // Invalid <View>some text</View> <View>{'some text'}</View> ``` ```jsx // Valid <View> <Text>some text</Text> </View> ``` Additional components can be allowlisted through the `skip` option: ```json { "options": { "skip": ["Title"] } } ``` - [#9911](biomejs/biome#9911) [`1603f78`](biomejs/biome@1603f78) Thanks [@Netail](https://github.com/Netail)! - Added the nursery rule [`noJsxLeakedDollar`](https://biomejs.dev/linter/rules/no-jsx-leaked-dollar), which flags text nodes with a trailing `$` if the next sibling node is a JSX expression. This could be an unintentional mistake, resulting in a '$' being rendered as text in the output. **Invalid**: ```jsx function MyComponent({ user }) { return <div>Hello ${user.name}</div>; } ``` - [#9999](biomejs/biome#9999) [`f42405f`](biomejs/biome@f42405f) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed `noMisleadingReturnType` incorrectly flagging functions with reassigned `let` variables. - [#10075](biomejs/biome#10075) [`295f97f`](biomejs/biome@295f97f) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [`#9983`](biomejs/biome#9983): Biome now parses functions declared inside Svelte `#snippet` blocks without throwing errors. - [#10006](biomejs/biome#10006) [`cf4c1c9`](biomejs/biome@cf4c1c9) Thanks [@minseong0324](https://github.com/minseong0324)! - Fixed [#9810](biomejs/biome#9810): `noMisleadingReturnType` incorrectly flagging nested object literals with widened properties. - [#10033](biomejs/biome#10033) [`11ddc05`](biomejs/biome@11ddc05) Thanks [@ematipico](https://github.com/ematipico)! - Added the nursery rule [`useReactNativePlatformComponents`](https://biomejs.dev/linter/rules/use-react-native-platform-components/) that ensures platform-specific React Native components (e.g. `ProgressBarAndroid`, `ActivityIndicatorIOS`) are only imported in files with a matching platform suffix. It also reports when Android and iOS components are mixed in the same file. The following code triggers the rule when the file does not have an `.android.js` suffix: ```js // file.js import { ProgressBarAndroid } from "react-native"; ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/Cloudflared-Runner/pulls/4

github-actions Bot added A-Linter Area: linter A-Parser Area: parser L-HTML Language: HTML and super languages labels Apr 14, 2026

Netail force-pushed the chore/rework-is-html-tag branch 6 times, most recently from 372c009 to d9e15d1 Compare April 14, 2026 23:28

github-actions Bot added the A-CLI Area: CLI label Apr 14, 2026

chore: rework html tag matcher

76b0c80

Netail force-pushed the chore/rework-is-html-tag branch from d9e15d1 to 76b0c80 Compare April 14, 2026 23:49

Netail marked this pull request as ready for review April 15, 2026 00:12

Netail changed the title ~~chore: rework html tag matcher~~ chore: abstract html tag matcher Apr 15, 2026

coderabbitai Bot reviewed Apr 15, 2026

View reviewed changes

Netail commented Apr 15, 2026

View reviewed changes

Comment thread crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs Outdated

Comment thread crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs Outdated

Netail added 2 commits April 15, 2026 02:30

Update crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs

7cfa616

Update crates/biome_html_analyze/src/lint/nursery/use_scoped_styles.rs

a799ccf

ematipico reviewed Apr 15, 2026

View reviewed changes

changeset

6962357

ematipico approved these changes Apr 15, 2026

View reviewed changes

Netail merged commit eabf54a into biomejs:main Apr 15, 2026
29 of 30 checks passed

Netail deleted the chore/rework-is-html-tag branch April 15, 2026 09:09

github-actions Bot mentioned this pull request Apr 15, 2026

ci: release #9991

Merged

Netail mentioned this pull request Apr 15, 2026

chore: abstract html tag matcher (main into next) #9993

Merged

This was referenced Apr 17, 2026

feat(linter): add noNonInteractiveTabIndex for HTML #9306

Merged

feat(html_analyze): implement noNoninteractiveElementToInteractiveRole #10022

Merged

This was referenced Apr 17, 2026

feat(html_analyze): implement noNoninteractiveElementInteractions #10026

Merged

feat(html_analyze): implement noStaticElementInteractions #10069

Merged

coderabbitai Bot mentioned this pull request Apr 26, 2026

feat(parse/html/vue): parse v-for better #8620

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: abstract html tag matcher#9988

chore: abstract html tag matcher#9988
Netail merged 4 commits intobiomejs:mainfrom
Netail:chore/rework-is-html-tag

Netail commented Apr 14, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

ematipico left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Netail commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed-hq Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

coderabbitai Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Netail commented Apr 14, 2026 •

edited

Loading

changeset-bot Bot commented Apr 14, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 14, 2026 •

edited

Loading

coderabbitai Bot commented Apr 15, 2026 •

edited

Loading