fix(core): file size diagnostic severity#9980
Merged
Conversation
🦋 Changeset detectedLatest commit: 2647031 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WalkthroughThis change addresses issue Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/every-poets-throw.md:
- Line 5: Update the changeset sentence to correct the grammar: replace "file
exceed the `files.maxSize` limit" with "file exceeds the `files.maxSize` limit"
so the user-facing line reads "Biome now emits a `warning` diagnostic when a
file exceeds the `files.maxSize` limit."; ensure the rest of the changeset text
and tense follow the project's guideline for concise, clear descriptions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c56bb05f-8536-4dba-8aa7-52628dc20ee9
⛔ Files ignored due to path filters (15)
crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_too_large_limit_check.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_cases_overrides_max_file_size/overrides_files_max_size_too_large_limit_format.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_check/file_too_large.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_check/file_too_large_cli_limit.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_check/file_too_large_config_limit.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_check/file_too_large_error_on_warnings.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_ci/file_too_large.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_ci/file_too_large_cli_limit.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_ci/file_too_large_config_limit.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_format/file_too_large.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_format/file_too_large_cli_limit.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_format/file_too_large_config_limit.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_lint/file_too_large.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_lint/file_too_large_cli_limit.snapis excluded by!**/*.snapand included by**crates/biome_cli/tests/snapshots/main_commands_lint/file_too_large_config_limit.snapis excluded by!**/*.snapand included by**
📒 Files selected for processing (3)
.changeset/every-poets-throw.mdcrates/biome_cli/tests/commands/check.rscrates/biome_service/src/diagnostics.rs
Conaclos
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9941
Test Plan
Added a new test
Docs