CodSpeed Performance Report

Merging #3217 will not alter performance

_{Comparing chansuke:fix/add-compose (6554e26) with chansuke:fix/add-compose (4cb079f)}

Summary

✅ 90 untouched benchmarks

Based on this message: #3000 (comment)

We need to modify the implementation so that it does not raise an error for the composes property if the css_modules option is enabled.

I wonder if there's a way to query the option in a rule context? We can get the file source from the context but css_modules is not a file source variant. @denbezrukov

Based on this message: #3000 (comment)

We need to modify the implementation so that it does not raise an error for the composes property if the css_modules option is enabled.

I wonder if there's a way to query the option in a rule context? We can get the file source from the context but css_modules is not a file source variant. @denbezrukov

Hm,
I’m not familiar with the analyzer infrastructure :(
I think if it’s not possible to get the option inside the rule, we can:

1. Just ignore it and not use the option.
2. Implement an option for the rule where we can add names to be ignored and extend it if the option is enabled.

I think if it’s not possible to get the option inside the rule, we can:

1. Just ignore it and not use the option.
2. Implement an option for the rule where we can add names to be ignored and extend it if the option is enabled.

I think ignoring the option to always accept composes is fine. We can wait for more feedbacks to decide whether to add a rule option.