Skip to content

Improvements#656

Merged
bkerler merged 1 commit intobkerler:masterfrom
sidneypepo:improvements
May 5, 2025
Merged

Improvements#656
bkerler merged 1 commit intobkerler:masterfrom
sidneypepo:improvements

Conversation

@sidneypepo
Copy link
Copy Markdown
Contributor

@sidneypepo sidneypepo commented Apr 27, 2025 •
edited
Loading

Improvements

  • Added Gentoo (unofficial) support

  • Added autoinstall script for Unixes

  • Added pylzma workaround for -Wint-conversion error (GCC >= 14)

  • Improved install-linux-edl-drivers.sh: now it's POSIX compliant and shell-agnostic

  • Improved Firehose cmd_peek() error handling (more details below)

  • Updated README.md

Extra information

About the cmd_peek() improvement, I've made it because this:

Traceback (most recent call last):
  File "/usr/bin/edl", line 4, in <module>
    __import__('pkg_resources').run_script('edlclient==3.62', 'edl')
  File "/usr/lib/python3.12/site-packages/pkg_resources/__init__.py", line 752, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/usr/lib/python3.12/site-packages/pkg_resources/__init__.py", line 1739, in run_script
    exec(code, namespace, namespace)
  File "/usr/lib/python3.12/site-packages/edlclient-3.62-py3.12.egg/EGG-INFO/scripts/edl", line 393, in <module>
    base.run()
  File "/usr/lib/python3.12/site-packages/edlclient-3.62-py3.12.egg/EGG-INFO/scripts/edl", line 385, in run
    if not fh.handle_firehose(cmd, options):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/edlclient-3.62-py3.12.egg/edlclient/Library/firehose_client.py", line 397, in handle_firehose
    if self.firehose.cmd_peek(target_name[0][0], target_name[0][1], filename, True):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/edlclient-3.62-py3.12.egg/edlclient/Library/firehose.py", line 1683, in cmd_peek
    rdata = self.xml.getlog(tmp)[0].replace("0x", "").replace(" ", "")
            ~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

happened when I tried to dump the PBL from a daisy (MSM8953). So on, I've noticed that this is caused by the received Firehose XML packets that were incomplete, so I made cmd_peek() to receive data until </data> is sent.

Beside this, the daisy's PBL is supposed to send 0x1ffb0 bytes from address 0x100000 (as it uses MSM8953), but it actually stops after sending 0x17fb2 bytes. This way, I've also made cmd_peek() to actually save the "truncated" data (I'm not sure why this is happening, but this workaround is actually working and the generated file is valid and reverse-engineerable).

Anyways, thanks for such amazing toolkit and related work! It's a truly life saver❣️

@sidneypepo
Improvements
765919e 
- Added Gentoo (unofficial) support

- Added autoinstall script for Unixes

- Added pylzma workaround for -Wint-conversion error

- Improved install-linux-edl-drivers.sh: now it's POSIX compliant and
shell-agnostic

- Improved Firehose cmd_peek() error handling

- Updated README.md
@bkerler bkerler merged commit 418ed09 into bkerler:master May 5, 2025
1 check failed
ybtag pushed a commit to ybtag/edl that referenced this pull request Apr 16, 2026
@bkerler
Merge pull request bkerler#656 from sidneypepo/improvements
1178d07 
Improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sidneypepo @bkerler