Small issues reported by Codacy#186
Conversation
68d6517 to
a405bf4
Compare
| // import java.io.File; | ||
| // import java.io.FileNotFoundException; | ||
| // import java.io.FileOutputStream; | ||
| // import java.io.PrintWriter; |
There was a problem hiding this comment.
Hi @cassiosantos, if you commented these imports out does than mean they are not used?
There was a problem hiding this comment.
Those modules are used by a part of extractNEs function which is commented out. It's probably some debugging stuff. We can remove these lines as well as PrintWriter code from extractNEs function
a405bf4 to
b3fca32
Compare
|
Generally I like this although we are planning on restructuring the repo and move services out. @cassiosantos do you have experience with continuous integration and specifically if generally people loop it in as part of that pipeline? curious to know your thoughts! |
|
@jhauswald restructuring the repository is a good idea. Continuous integration comes with a set of good practices. I think it isn't necessary to use CI to take the advantage of automation. I think that automated tests and builds could help people to contribute to the project. |
b3fca32 to
cc9566d
Compare
returnstatementsequalsIgnoreCase()is cleaner than usingtoUpperCase/toLowerCase().equals()