Fix #5524: automatically export new COCOTB_ prefixes variables in...#5527
Open
mattiagaggi wants to merge 1 commit intococotb:masterfrom
Open
Conversation
…s in Makefiles In Makefile.inc, add export statements for COCOTB_TEST_MODULES, COCOTB_TESTCASE, COCOTB_TEST_FILTER, COCOTB_TOPLEVEL, and TOPLEVEL_LANG (applying the deprecation fallback logic before exporting). Then remove the redundant inline VAR=value environment variable prefixes from every simulator Makefile's run command lines, since the exported variables will already be in the environment.
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralize the export of
COCOTB_-prefixed environment variables inMakefile.incinstead of repeating inlineVAR=valueprefixes on every simulator's command line. This reduces duplication across all 13 simulator Makefiles and ensures newCOCOTB_variables are automatically available to subprocesses.Changes
COCOTB_TEST_MODULES(fromMODULE) andCOCOTB_TESTCASE(fromTESTCASE) inMakefile.deprecations, matching the existing pattern forCOCOTB_TOPLEVEL/TOPLEVELCOCOTB_TEST_MODULES,COCOTB_TESTCASE,COCOTB_TEST_FILTER,COCOTB_TOPLEVEL,TOPLEVEL_LANG, andGPI_EXTRAcentrally inMakefile.incTesting
COCOTB_TEST_MODULES,COCOTB_TESTCASE,COCOTB_TEST_FILTER, andCOCOTB_TOPLEVELpropagate correctlyMODULE,TESTCASE,TOPLEVEL) still work and trigger deprecation warningsmake COCOTB_TEST_FILTER=test_foo simfilters tests as expectedCOCOTB_-prefixed variablesCloses #5524