Make simulator version objects more useful#5530
Open
zeel2104 wants to merge 1 commit intococotb:masterfrom
Open
Make simulator version objects more useful#5530zeel2104 wants to merge 1 commit intococotb:masterfrom
zeel2104 wants to merge 1 commit intococotb:masterfrom
Conversation
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make simulator version objects more useful by replacing the current
LooseVersion-style behavior with simulator-aware parsing and comparison.This change adds common constructors for building version objects from
cocotb.SIM_VERSIONand from simulator command output, including a zero-argumentfrom_commandline()path that invokes the simulator automatically when possible. It also updates existing call sites to use the new convenience API.The main motivation is that several supported simulators use version strings that do not compare correctly with the current implementation, especially when they include release metadata, development tags, suffix letters, or train names. This patch makes those comparisons behave more like users expect and makes the version helpers easier to use in tests.
Changes:
SimulatorVersionbase with explicit parsing/comparison behaviorfrom_sim_version()and improvedfrom_commandline()constructorsTesting:
$env:PYTHONPATH='d:\cocotb\src'; python -m pytest tests\pytest\test_sim_versions.pyI could not exercise the zero-argument subprocess path against real simulator executables in this shell because no supported simulators were installed on
PATH, but the parsing and comparison behavior is covered by unit tests.Closes #5520