Export COCOTB_, GPI_, PYGPI_ prefixed variables in Makefiles#5531
Open
RahulSannapureddy wants to merge 3 commits intococotb:masterfrom
Open
Export COCOTB_, GPI_, PYGPI_ prefixed variables in Makefiles#5531RahulSannapureddy wants to merge 3 commits intococotb:masterfrom
RahulSannapureddy wants to merge 3 commits intococotb:masterfrom
Conversation
Updated Makefile.inc to export COCOTB_TEST_FILTER, COCOTB_TEST_MODULES, COCOTB_RANDOM_SEED, etc. so they are passed to the simulator run just like the MODULE variable. Also refactored the simulator makefiles to reflect this change. Fixes cocotb#5524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
Makefile.incto exportCOCOTB_TEST_FILTER,COCOTB_TEST_MODULES, andCOCOTB_RANDOM_SEEDso they are automatically passed to the simulator run, mirroring the behavior of theMODULEvariable.I also refactored the individual simulator makefiles to reflect this global export and remove redundant passing logic.
Fixes #5524
PR Checklist
tests/test_cases/. (N/A: Existing regression tests verify Makefile behavior)docs/source/, docstrings in Python code, or Doxygen markup in C/C++ code. (N/A: Internal Makefile variables)docs/source/newsfragments/README.rst.closes #XXXXto auto-close the issue that this PR fixes (if such).