Skip to content

feat(v3): string cuid validation#438

Closed
alii wants to merge 4 commits intocolinhacks:v3from
alii:v3
Closed

feat(v3): string cuid validation#438
alii wants to merge 4 commits intocolinhacks:v3from
alii:v3

Conversation

@alii
Copy link
Copy Markdown
Contributor

@alii alii commented May 15, 2021

This PR adds cuid validation to a string. This is my first time contributing to Zod I'm sure I've probably left something out 😅

@alii alii changed the title feat: string cuid validation feat(v3): string cuid validation May 15, 2021
@alii
Copy link
Copy Markdown
Contributor Author

alii commented Jul 8, 2021

Any update on this 😀

@carlpaten
Copy link
Copy Markdown
Collaborator

Maybe there's a discussion I missed so take this with a grain of salt:

I don't think the goal of Zod is to provide an exhaustive collection of validators. Rather, it's meant to be easy to extend with your own validators.

I'm not familiar with CUID. The NPM package of the same name has under a million weekly downloads, so it's not exactly pervasive. Based on what little I know, I wouldn't recommend it for inclusion in the core Zod library.

@colinhacks
Copy link
Copy Markdown
Owner

Despite appearances, this was merged in [email protected]. Thanks @alii!

@colinhacks colinhacks closed this Aug 23, 2021
@alii
Copy link
Copy Markdown
Contributor Author

alii commented Aug 23, 2021

yay!

@alii alii deleted the v3 branch August 23, 2021 10:22
@alii
Copy link
Copy Markdown
Contributor Author

alii commented Aug 23, 2021

thanks colin for epic library
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants