feat(v3): string cuid validation#438
Closed
alii wants to merge 4 commits intocolinhacks:v3from
Closed
Conversation
Contributor
Author
|
Any update on this 😀 |
Collaborator
|
Maybe there's a discussion I missed so take this with a grain of salt: I don't think the goal of Zod is to provide an exhaustive collection of validators. Rather, it's meant to be easy to extend with your own validators. I'm not familiar with CUID. The NPM package of the same name has under a million weekly downloads, so it's not exactly pervasive. Based on what little I know, I wouldn't recommend it for inclusion in the core Zod library. |
Owner
|
Despite appearances, this was merged in |
Contributor
Author
|
yay! |
Contributor
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds cuid validation to a string. This is my first time contributing to Zod I'm sure I've probably left something out 😅