Merged
Conversation
Owner
colinhacks
commented
Oct 16, 2025
- WIP
- WIP
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on optimizing the initialization performance of Zod schemas by reducing unnecessary computations during schema construction. The changes eliminate deferred attachment callbacks in favor of direct property assignments and streamline the initialization logic in the core $constructor function.
Key Changes:
- Refactored
$constructorto initialize_zodproperties upfront and prevent duplicate initialization - Replaced deferred
onattachcallbacks with direct property assignments for format types (IPv4, IPv6, Base64, Base64URL) - Optimized prototype method binding using indexed loops instead of for-in loops
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/zod/src/v4/core/core.ts | Core initialization logic optimized to set properties directly and avoid redundant work |
| packages/zod/src/v4/core/schemas.ts | Removed onattach callbacks, replaced with direct property assignments; fixed constructor names and typos |
| packages/zod/src/v4/mini/iso.ts | Corrected constructor names from internal $Zod* format to public ZodMini* format |
| packages/zod/src/v4/classic/schemas.ts | Minor whitespace cleanup |
| packages/bench/*.ts | Code formatting improvements and addition of initialization benchmark test |
| packages/bench/tsconfig.json | Disabled unused variable/parameter checks for benchmark code |
| biome.jsonc | Removed packages/bench from lint ignore list |
| play.ts | Updated example to test uint32 parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.