change exec stdio on default#4
Open
aokomyshan wants to merge 2 commits intodvonlehman:masterfrom
Open
Conversation
added 2 commits
January 31, 2020 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. In current version of module (1.0.2) exec of command in case of ec2 instance write 'ec2' in stdout. Such behaviour is critical for me, because I have wrong data in stdout because of 'ec2' string adding. If use default stdio for exec ('pipe') there isn't 'ec2' in stdout. I tested added changes locally and in ec2 instance, in first case function returns false, in second case it returns true. I will really appreciate if you merge this fix.