Skip to content

Groups#169

Draft
SimonLab wants to merge 13 commits intomainfrom
group
Draft

Groups#169
SimonLab wants to merge 13 commits intomainfrom
group

Conversation

@SimonLab
Copy link
Copy Markdown
Member

@SimonLab SimonLab commented Oct 8, 2022

Create groups:
many_to_many groups - lists
many_to_many groups - people

Create the lists table
Create list controller to add and edit lists
Create item controller to link items to lists
- Add/Remove list linked to an item
- Display lists as badges on main page
Check if person exist before insert
Add schemas and controllers tests
- Add test for item controller managing lists
- Fix #168
Create migration, schema and controller for groups
@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 8, 2022
@SimonLab SimonLab self-assigned this Oct 8, 2022
@SimonLab SimonLab temporarily deployed to dwylauth October 8, 2022 22:28 Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2022

Codecov Report

❌ Patch coverage is 50.00000% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.47%. Comparing base (7d05242) to head (3827047).
⚠️ Report is 996 commits behind head on main.

Files with missing lines Patch % Lines
lib/app_web/controllers/group_controller.ex 0.00% 19 Missing ⚠️
lib/app_web/controllers/group_list_controller.ex 0.00% 17 Missing ⚠️
lib/app_web/controllers/group_member_controller.ex 0.00% 10 Missing ⚠️
lib/app/group.ex 20.00% 8 Missing ⚠️
lib/app/person.ex 50.00% 2 Missing ⚠️
lib/app/group_list.ex 0.00% 1 Missing ⚠️
lib/app/group_person.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #169       +/-   ##
============================================
- Coverage   100.00%   82.47%   -17.53%     
============================================
  Files           13       23       +10     
  Lines          219      331      +112     
============================================
+ Hits           219      273       +54     
- Misses           0       58       +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add functions in Person schema to get the list of groups.
@SimonLab SimonLab temporarily deployed to dwylauth October 9, 2022 14:00 Inactive
Create controller and templates for group members
@SimonLab SimonLab temporarily deployed to dwylauth October 9, 2022 20:53 Inactive
Add member to group display errors if person not found
@SimonLab SimonLab temporarily deployed to dwylauth October 10, 2022 08:26 Inactive
@nelsonic
Copy link
Copy Markdown
Member

@SimonLab in light of my comment in dwyl/auth#220 (comment) I made the case that groups belong in the auth application where all personally identifiable info is stored.
I think it makes sense to add groups to the MVP for speed.
But ultimately we should not be duplicating the people table in two places.
Personally identifiable data should exclusively be stored in the Auth App which will be deployed on separate infrastructure.

For the purposes of adding collaboration to the MVP we can add people and groups here,
but this is not where this data will be stored longer term because we don't want to mix the concerns.

@SimonLab SimonLab temporarily deployed to dwylauth October 10, 2022 13:51 Inactive
Create group_list_controller to add lists to groups
@SimonLab SimonLab temporarily deployed to dwylauth October 10, 2022 14:05 Inactive
Update group name
Delete group
@SimonLab SimonLab temporarily deployed to dwylauth October 10, 2022 15:07 Inactive
@SimonLab SimonLab mentioned this pull request Oct 11, 2022
10 tasks
@SimonLab SimonLab removed the in-progress An issue or pull request that is being worked on by the assigned person label Nov 30, 2022
@SimonLab SimonLab removed their assignment Nov 30, 2022
@nelsonic nelsonic changed the title Group Groups Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants