Skip to content

linter: fix errors by removing 'no-self-use' #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbrodehl merged 2 commits into from
Jul 20, 2022
Merged

linter: fix errors by removing 'no-self-use' #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dec2066
linter: ignore C3001 unnecessary-lambda-assignment
da-h Jul 20, 2022
554f11d
linter: fix errors by removing 'no-self-use'
da-h Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/linting-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Static Analysis
run: |
flake8 src --count --ignore E501 --statistics
pylint -d W0511 -d C0114 -d C0116 -d C0115 -d C0301 -d C0302 -d C0303 -d C0103 -d C0209 -d R0913 -d R0914 -d R0902 -d R0912 -d R0801 -d R1702 -d W0212 -d W0223 -d E1101 -d W0221 -d E1102 src/miniflask
pylint -d W0511 -d C0114 -d C0116 -d C0115 -d C0301 -d C0302 -d C0303 -d C0103 -d C0209 -d C3001 -d R0913 -d R0914 -d R0902 -d R0912 -d R0801 -d R1702 -d W0212 -d W0223 -d E1101 -d W0221 -d E1102 src/miniflask
pylint --exit-zero src/miniflask
- name: Syntax Check of Tests
run: |
Expand All @@ -37,5 +37,5 @@ jobs:
- name: Static Analysis of Tests (Modules)
run: |
flake8 tests --count --ignore E501 --statistics
pylint -d W0511 -d C0114 -d C0116 -d C0115 -d C0301 -d C0302 -d C0303 -d C0103 -d C0209 -d R0913 -d R0914 -d R0902 -d R0912 -d R0801 -d W0212 -d W0223 -d E1101 -d W0221 -d E1102 `find tests -type f -name '.module' -printf '%h\0' | sort -zu | sed -z 's/$/\n/'`
pylint -d W0511 -d C0114 -d C0116 -d C0115 -d C0301 -d C0302 -d C0303 -d C0103 -d C0209 -d C3001 -d R0913 -d R0914 -d R0902 -d R0912 -d R0801 -d W0212 -d W0223 -d E1101 -d W0221 -d E1102 `find tests -type f -name '.module' -printf '%h\0' | sort -zu | sed -z 's/$/\n/'`
pylint --exit-zero `find tests -type f -name '.module' -printf '%h\0' | sort -zu | sed -z 's/$/\n/'`
2 changes: 1 addition & 1 deletion src/miniflask/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ def __deepcopy__(self, memo):
del memo
return self

def outervar(self): # pylint: disable=no-self-use
def outervar(self):
r"""!outervar
For debbuging mainly: Changing the variables an event is called with.

Expand Down
2 changes: 1 addition & 1 deletion src/miniflask/miniflask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,7 +1310,7 @@ def set_scope(self, new_module_name):
return new_module_name

# wrapper for the optional class
def optional(self, variable_type): # pylint: disable=no-self-use
def optional(self, variable_type):
r"""
Define optional variables.

Expand Down