Skip to content

Bugfix: CLI argument without value (i.e. a boolean setting) raises Exception#103

Merged
da-h merged 3 commits intomasterfrom
bugfix_cli_argument_without_value_error
Nov 24, 2021
Merged

Bugfix: CLI argument without value (i.e. a boolean setting) raises Exception#103
da-h merged 3 commits intomasterfrom
bugfix_cli_argument_without_value_error

Conversation

@da-h
Copy link
Copy Markdown
Owner

@da-h da-h commented Nov 24, 2021

Bugfix: CLI argument without value (i.e. a boolean setting) raises Exception

This MR fixes an error due to a recent change in miniflask v4.0, given in MR #96.

Description

The bug was that no boolean setting could be set anymore using the notation --boolsetting.

This MR fixes this issue and includes the missing unit test that should test against this kind of use.

Check all before creating this PR:

  • unit tests adapted / created

@da-h da-h force-pushed the bugfix_cli_argument_without_value_error branch from 067acb3 to 0044a1a Compare November 24, 2021 15:29
@da-h da-h merged commit a3cf72e into master Nov 24, 2021
github-actions Bot pushed a commit that referenced this pull request Nov 24, 2021
…rror

Bugfix: CLI argument without value (i.e. a boolean setting) raises Exception
@sbrodehl sbrodehl deleted the bugfix_cli_argument_without_value_error branch October 7, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant