Skip to content

Fix linter errors#113

Merged
da-h merged 2 commits intomasterfrom
fix_linter_errors2
Oct 6, 2022
Merged

Fix linter errors#113
da-h merged 2 commits intomasterfrom
fix_linter_errors2

Conversation

@da-h
Copy link
Copy Markdown
Owner

@da-h da-h commented Oct 5, 2022

Fix some linter errors & local pytest

Description

Problem:

  1. Flake8 got puzzled by a test-folder named dataclass that itself used the python-package dataclass. The test-folder has been changed to dataclass_as_state.
  2. Fixed flake8's error modified-iterating-list.

Check all before creating this PR:

  • Documentation adapted
  • unit tests adapted / created

@da-h da-h requested a review from sbrodehl October 5, 2022 14:22
@da-h da-h force-pushed the fix_linter_errors2 branch from 5b3eacf to 629744c Compare October 5, 2022 14:23
@da-h da-h mentioned this pull request Oct 5, 2022
2 tasks
@sbrodehl
Copy link
Copy Markdown
Collaborator

sbrodehl commented Oct 5, 2022

Running pytest (without the dot) seems to work just fine, but running python -m pytest fails.
I think there is a bigger problem here, because miniflasks sys.argv usage seems very intrusive and everything fails when not used directly.
Another example here is the usage of CLI arguments to pytest, e.g. specifically pointing to the test directory via pytest tests/ fails, because miniflask is looking for a module called tests/ 🤔
What's your take on this?

@da-h da-h force-pushed the fix_linter_errors2 branch from 629744c to 91b9ba1 Compare October 6, 2022 09:49
@da-h
Copy link
Copy Markdown
Owner Author

da-h commented Oct 6, 2022

After looking into this again, it seems that this might be related to #114 in my setup.
(Again exactly those tests fail that load the module setup that exists on my setup as a python package. See #114 for details).

I have removed the pytest fix out of this MR and will look into this later again.

@da-h da-h merged commit 4a75f9b into master Oct 6, 2022
@da-h da-h deleted the fix_linter_errors2 branch October 6, 2022 09:52
github-actions Bot pushed a commit that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants