state: improve lambda regex, allowing any key name#124
Merged
Conversation
Collaborator
|
We should add the possibility to use single quotation marks, not only double quotation marks. |
Collaborator
Sorry, didn’t checked this before! Looks good to me. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURENAME
This MR fixes the failing test introduced in #123.
Description
Problem
was that the regex did not match any string, but only keys consisting of proper words (i.e.
"anyword").New Behavior:
the new string-regex allows any string using
"[^"]*"syntax instead. Also, this PR adds the possibility to use single quotation marks for the keys.