Merged
Conversation
…vents=True/False)
…n (also in overwrite_event)
sbrodehl
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep attached events on overwriting
Attention: This is a breaking change.
This MR changes the way events are overwritten/redefined using
mf.unregister_eventormf.overwrite_event.Description
By default, a call to any of the mentioned methods, all events of the given name are unregistered from miniflask (either only their function cache or any of their future uses), and also all events that are attached to the event to be changed.
A typical used-case, however is the transformation of events using other modules using
before_andafter_event hooks (attached events). With other words, replacing an event should not replace the hooks used to modify or inspect the calls when changing its function.This MR thus, by default, keeps all attached events upon reregistration, but allows the user to remove all additional (typically) user-events as well.
Things done in this MR
keep_attached_eventstomf.unregister_eventandmf.overwrite_eventCheck all before creating this PR: