mf: set_scope should set absoulte id (without repository base name)#87
Merged
mf: set_scope should set absoulte id (without repository base name)#87
Conversation
e98dc98 to
bed31a1
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
mf: set_scope should set absoulte id (without repository base name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
set_scopecannot set global id.Api-Change: This MR reenables
set_scopeto define the global id of a module.Previously,
mf.set_scope(name)would prefix the name with the module repository id the module is defined in.It was not possible to adapt the scope of another repository.
After this MR, any module can share the scope with any other module.
(Related to #79)