Conversation
sbrodehl
reviewed
Nov 11, 2021
| assert len(state.all) == 4, "Found global Variables %i" % len(state.all) | ||
|
|
||
| # Check if local state iterator has all variables that we expect | ||
| assert len(state) == 1, "Found lokal Variables %i" % len(state) |
Owner
Author
There was a problem hiding this comment.
Thx. Fix added to next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented State using ABC base class
This MR adapts the implementation of
stateto use python's ABC base classes instead of extendingdict.This change allows to iterate over the variables in a module.
Description
Some dict-operations could not be used on
statevariables (see #71).This MR solves this by letting
collections.abc.MutableMappingcheck if any functions are missing for a complete dict-implementation.Things done in this MR
stateclass fromMutableMappingtemporary_stateas it has never been usediter(state)andlen(state).Check all before creating this PR: