Replaced attached properties with hidden database#92
Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
Replaced attached properties with hidden database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Replaced attached properties with hidden database
Attention: This is a breaking change.
This MR changes the way miniflask saves data that relates to the wrapped event functions.
Previously:
To solve this, the
eventobject now contains a hidden_datadictionary that saves this information.New Behavior:
event._data[eventname]contains the dictionary with all information required to construct the eventsevent._data[eventname]["modules"]: list of modules that define the eventeventnameevent._data[eventname]["wrapped_event"]: symlink toevent.eventnameevent._data[eventname]["wrapped_single_events"]: list of all wrapped events in case of non-unique eventeventnameevent._data[eventname]["raw_functions"]: list of all raw functions (as defined in code) in the modules given above (same order as in the modules list)event._data[eventname]["raw_function_args"]: themf,stateandeventobjects arguments needed for the raw functionsCheck all before creating this PR: