Skip to content

fix: updated google drive implementation#600

Merged
rupato-deriv merged 1 commit intoderiv-com:masterfrom
rupato-deriv:Rupato/Update--google-drive-implmentation
Nov 4, 2025
Merged

fix: updated google drive implementation#600
rupato-deriv merged 1 commit intoderiv-com:masterfrom
rupato-deriv:Rupato/Update--google-drive-implmentation

Conversation

@rupato-deriv
Copy link
Copy Markdown
Contributor

This pull request improves the robustness and reliability of Google Drive integration in the GoogleDriveStore class. The main changes focus on enhanced token validation, better error handling during file operations, and improved API request configuration to ensure smoother uploads and downloads.

Authentication and Token Validation:

  • Added a check to ensure access_token exists before verifying, and implemented a call to Google's tokeninfo endpoint to validate the token, with proper error handling and user notification if invalid. [1] [2]

Error Handling and Event Reporting:

  • Improved error handling in file download by validating XML content and reporting failures via rudderStackSendUploadStrategyFailedEvent, including specific error messages and codes.
  • Updated event reporting for upload failures to use a more type-safe approach for the upload_provider field. [1] [2]

API Request Improvements:

  • Enhanced upload requests by adding Accept: application/json and X-Goog-Upload-Protocol: multipart headers for better compatibility with Google Drive API.

File Content Validation:

  • Added basic XML validation for downloaded files to ensure only valid XML content is processed, with error handling for invalid content.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 4, 2025

Preview Link: https://Rupato-Update--googl.bot-65f.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@rupato-deriv rupato-deriv merged commit 0e316a6 into deriv-com:master Nov 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant