Merged
Conversation
Contributor
|
Preview Link: https://Rupato-Fix-google-dr.bot-65f.pages.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the Google Drive integration by improving error handling, enhancing logging for better debugging, and updating the OAuth scope to support broader file access. The changes focus on making the file download process more robust, ensuring only owned files are shown in the picker, and providing clearer feedback in case of authentication or permission issues.
Google Drive API integration improvements:
drive.filetodrive, allowing access to all files the user can see, not just those created by the app. (src/external/bot-skeleton/constants/config.ts)gapi.client.drive.files.getinstead of rawfetch, added token validity checks before downloading, and improved error handling for common API errors (401, 403, 404) with user-friendly messages and forced sign-out on authentication failure. (src/stores/google-drive-store.ts)Logging and debugging enhancements:
src/stores/google-drive-store.ts) [1] [2]src/stores/google-drive-store.ts) [1] [2] [3] [4] [5]User experience improvements:
owner:me), preventing selection of shared files that may not be downloadable due to permission issues. (src/stores/google-drive-store.ts)