Skip to content

upgrade toolchain to 1.95#90

Merged
dhth merged 2 commits intomainfrom
upgrade-toolchain-to-1-95
Apr 22, 2026
Merged

upgrade toolchain to 1.95#90
dhth merged 2 commits intomainfrom
upgrade-toolchain-to-1-95

Conversation

@dhth
Copy link
Copy Markdown
Owner

@dhth dhth commented Apr 22, 2026

Summary

  • Upgrade the Rust toolchain to 1.95.
  • Rely on GitHub Actions for validation and investigate only failing checks.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b9045d3-df22-4879-939c-e2f5b1ebd83e

📥 Commits

Reviewing files that changed from the base of the PR and between d41185f and 568a138.

📒 Files selected for processing (2)
  • rust-toolchain.toml
  • src/report/io.rs
📝 Walkthrough

Walkthrough

This pull request makes two changes across the repository. First, the Rust toolchain version is updated from 1.94 to 1.95 in the toolchain configuration file. Second, the sorting logic in the report IO module is refactored to use a key-based approach with Reverse instead of a comparator-based approach for descending sorts in two functions: keep_last_n_outputs and gather_run_data. A corresponding import for Reverse is added to support the updated implementation.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'upgrade toolchain to 1.95' directly and clearly summarizes the main changes in the PR, which updates rust-toolchain.toml from 1.94 to 1.95 and addresses Clippy warnings for the new toolchain version.
Description check ✅ Passed The description is related to the changeset, mentioning the toolchain upgrade to 1.95 and referencing validation checks, which aligns with the actual changes made including the toolchain update and Clippy warning fixes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dhth dhth merged commit 1447340 into main Apr 22, 2026
17 checks passed
@dhth dhth deleted the upgrade-toolchain-to-1-95 branch April 22, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dhth