Skip to content

added silly test for empty file warning#557

Merged
mr-c merged 1 commit intodib-lab:masterfrom
wltrimbl:onemoretest
Apr 10, 2015
Merged

added silly test for empty file warning#557
mr-c merged 1 commit intodib-lab:masterfrom
wltrimbl:onemoretest

Conversation

@wltrimbl
Copy link
Copy Markdown
Collaborator

No description provided.

@ctb
Copy link
Copy Markdown
Member

ctb commented Jul 23, 2014

Hi @wltrimbl, thanks for your PR! The build failed, and two pep8 problems caused the failed build:

tests/test_script_arguments.py:41:1: E302 expected 2 blank lines, found 1
tests/test_script_arguments.py:51:1: W391 blank line at end of file

@ctb
Copy link
Copy Markdown
Member

ctb commented Jul 23, 2014

You can try this yourself with

pip install pep8
make pep8

@ctb
Copy link
Copy Markdown
Member

ctb commented Jul 24, 2014

Let us know when you're ready for review -- thanks!

@mr-c
Copy link
Copy Markdown
Contributor

mr-c commented Aug 18, 2014

This is being bumped to the 1.2+ release. Unless @wltrimbl wants to finish it, others are welcome to wrap up this pull request.

@mr-c mr-c added this to the 1.1 + 2 milestone Aug 18, 2014
@ctb
Copy link
Copy Markdown
Member

ctb commented Sep 9, 2014

ping @wltrimbl?

@SensibleSalmon
Copy link
Copy Markdown
Contributor

@mr-c I'll finish this up.

@SensibleSalmon SensibleSalmon self-assigned this Apr 7, 2015
@mr-c mr-c merged commit 4218a2f into dib-lab:master Apr 10, 2015
mr-c added a commit that referenced this pull request Apr 10, 2015
Migrating from #557: "added silly test for empty file warning"
@wltrimbl wltrimbl deleted the onemoretest branch June 26, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants