Sidekiq 8#1
Closed
fbherling wants to merge 8 commits intodigineo:mainfrom
Closed
Conversation
This primarily adds support for Sidekiq 7. The support policy for Sidekiq states that the previous major releases is supported "as long as they are less than five years old" [1]. With Sidekiq 6.0 released in August 2019, that time has come. This also adds an exhaustive test matrix covering - Ruby 3.0..3.3 - Sidekiq 6.5..7.3 - official Redis server and its ValKey fork Testing against ValKey ensures smooth transitioning from the proprietary Redis 7.2 to a pure Open Source stack [2, 3]. [1]: https://github.com/sidekiq/sidekiq/wiki/Commercial-Support [2]: https://redis.io/legal/licenses/ [3]: https://github.com/valkey-io/valkey?tab=License-1-ov-file#readme
The runner keep alive thread may call `MiniScheduler::Manager#keep_alive` before the `@runner` instance variable has been assigned in `MiniScheduler::Manager#initialize`. Since `MiniScheduler::Manager#keep_alive` expects the `@runner` instance variable to not be `nil`, an error ends up being raised. ``` Failure/Error: ids = [identity_key, *@runner.worker_thread_ids] if ids.size == 0 NoMethodError: undefined method `worker_thread_ids' for nil /var/www/discourse/vendor/bundle/ruby/3.3.0/gems/mini_scheduler-0.18.0/lib/mini_scheduler/manager.rb:360:in `keep_alive' /var/www/discourse/vendor/bundle/ruby/3.3.0/gems/mini_scheduler-0.18.0/lib/mini_scheduler/manager.rb:40:in `keep_alive' /var/www/discourse/vendor/bundle/ruby/3.3.0/gems/mini_scheduler-0.18.0/lib/mini_scheduler/manager.rb:31:in `block (2 levels) in initialize' /var/www/discourse/vendor/bundle/ruby/3.3.0/gems/mini_scheduler-0.18.0/lib/mini_scheduler/manager.rb:31:in `synchronize' /var/www/discourse/vendor/bundle/ruby/3.3.0/gems/mini_scheduler-0.18.0/lib/mini_scheduler/manager.rb:31:in `block in initialize' ```
Updates the requirements on [mocha](https://github.com/freerange/mocha) to permit the latest version. - [Changelog](https://github.com/freerange/mocha/blob/main/RELEASE.md) - [Commits](freerange/mocha@v2.0.0...v3.0.1) --- updated-dependencies: - dependency-name: mocha dependency-version: 3.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [sidekiq](https://github.com/sidekiq/sidekiq) to permit the latest version. - [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md) - [Commits](sidekiq/sidekiq@v6.5.0...v7.3.10) --- updated-dependencies: - dependency-name: sidekiq dependency-version: 7.3.10 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Member
|
see discourse#65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Sidekiq ~> 8.1.0