Add overflow protection to LZW buffer allocation#107
Open
uwezkhan wants to merge 1 commit intodloebl:mainfrom
Open
Add overflow protection to LZW buffer allocation#107uwezkhan wants to merge 1 commit intodloebl:mainfrom
uwezkhan wants to merge 1 commit intodloebl:mainfrom
Conversation
Owner
|
Hey @uwezkhan, Missing test case (required): Bug fix PRs must include a test in AI tooling attribution: If any AI models or tooling were used to produce this PR, please disclose that per our contributing guidelines (CONTRIBUTING.md:, item 5). |
4ff2400 to
07bf827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds explicit overflow guards to the LZW
buffer allocation in cgif_raw.c.
The allocation size is derived from:
Without guarding against additive and multiplicative
overflow, extreme dimension values could cause the
computed allocation size to wrap, leading to an
undersized heap allocation and potential out-of-bounds
writes during LZW encoding.
The patch introduces:
No public API changes.
No behavioral changes for valid inputs.
Negligible runtime impact.
Security impact:
Prevents potential heap buffer overflow in the LZW
encoding path due to allocation size wraparound.