LZW_GenerateStream() allocated the LZW code buffer using:#100
Closed
rootvector2 wants to merge 1 commit intodloebl:mainfrom
Closed
LZW_GenerateStream() allocated the LZW code buffer using:#100rootvector2 wants to merge 1 commit intodloebl:mainfrom
rootvector2 wants to merge 1 commit intodloebl:mainfrom
Conversation
sizeof(uint16_t) * (numPixel + 2 + maxResets) The size expression was computed in 32-bit arithmetic, allowing unsigned overflow when numPixel is large. This could result in an undersized allocation and subsequent out-of-bounds writes to pLZWData during LZW code emission. Fix by: - Performing size calculation in size_t - Adding explicit overflow checks for addition and multiplication - Recording allocated capacity - Adding bounds checks before all pLZWData writes This change does not alter encoder behavior for valid inputs and adds negligible overhead.
Owner
Owner
|
Resolved with #103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size expression was computed in 32-bit arithmetic, allowing unsigned overflow when numPixel is large. This could result in an undersized allocation and subsequent out-of-bounds writes to pLZWData during LZW code emission.
Fix by:
This change does not alter encoder behavior for valid inputs and adds negligible overhead.