allow external user ID as username#75
Open
nebulon42 wants to merge 1 commit intodominik-th:4.x-devfrom
Open
Conversation
…e-mail address as Matomo user ID (fixes dominik-th#65)
|
@dominik-th Could this be merged? |
gramakri
added a commit
to cloudron-io/matomo-plugin-LoginOIDC
that referenced
this pull request
Nov 11, 2024
apply kde-changes patch Patch is from dominik-th#95 Related: dominik-th#119 dominik-th#65 dominik-th#75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a setting to allow to use user IDs coming from the identity provider as Matomo username instead of the e-mail address. Keeps backwards compatibility because the setting defaults to the current behaviour. Once unticked it relies on the correct mapping of userinfo ID to populate the username.
fixes #65