Avoid conflict between Auth methods#116
Open
tacerus wants to merge 1 commit intodominik-th:5.x-devfrom
Open
Conversation
Resolve: ``` ERROR Piwik\FrontController Uncaught exception: Error: Call to undefined method Piwik\Plugins\Login\Auth::setForceLogin() in /srv/www/matomo/plugins/LoginOIDC/Controller.php:431 ``` It seems it loaded the methods from Piwik\Auth instead of Piwik\Plugins\LoginOIDC\OIDCAuth - which worked for getLogin() (which exists in both files), but failed at setForceLogin() (which only exists in the latter). Signed-off-by: Georg Pfuetzenreuter <[email protected]>
|
A fix for this has been added to the fork at: https://github.com/Digitalist-Open-Cloud/Matomo-Plugin-RebelOIDC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve:
It seems it loaded the methods from Piwik\Auth instead of Piwik\Plugins\LoginOIDC\OIDCAuth - which worked for getLogin() (which exists in both files), but failed at setForceLogin() (which only exists in the latter).