Add basic format option#114
Merged
dominikbraun merged 2 commits intodominikbraun:mainfrom Jun 12, 2021
sfrique:issue-109/add-format
Merged
Add basic format option#114dominikbraun merged 2 commits intodominikbraun:mainfrom sfrique:issue-109/add-format
dominikbraun merged 2 commits intodominikbraun:mainfrom
sfrique:issue-109/add-format
Conversation
Owner
dominikbraun
left a comment
There was a problem hiding this comment.
This looks pretty good to me! I'd merely suggest to directly return in case a format flag has been provided, to better indicate that this flag is a point of return in the program.
Co-authored-by: Dominik Braun <[email protected]>
Owner
|
FYI: I briefly renamed two of the formatting variables, see #123. |
Contributor
Author
Cool, I reviewed the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial very basic implementation for #109
I didn't write any test and actually used
fmt.Printfshould I create anout.Printfor something like this?Please any suggestions are welcome, I am not really a golang dev =P
To have better options to replace and format, we would need to add more information to the status command.