Skip to content

#145 handle nil pointer dereference for tracked record#150

Merged
dominikbraun merged 2 commits intodominikbraun:mainfrom
alksmt:#145-fixing-tracked-record-panic
Jul 5, 2021
Merged

#145 handle nil pointer dereference for tracked record#150
dominikbraun merged 2 commits intodominikbraun:mainfrom
alksmt:#145-fixing-tracked-record-panic

Conversation

@alksmt
Copy link
Copy Markdown
Contributor

@alksmt alksmt commented Jun 30, 2021

PR for #145

Changes:

  • Fixing issue with nil pointer dereference during collides check against tracked record
  • Simplified collides check conditions (here's a good reference for it: Date ranges overlap check)
  • Added missing test cases for complete records and new ones for records that are being tracked

alksmt added 2 commits June 30, 2021 13:52
Copy link
Copy Markdown
Collaborator

@aligator aligator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikbraun dominikbraun linked an issue Jul 4, 2021 that may be closed by this pull request
Copy link
Copy Markdown
Owner

@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@dominikbraun dominikbraun merged commit 7f2ae91 into dominikbraun:main Jul 5, 2021
@dominikbraun
Copy link
Copy Markdown
Owner

This PR is included in timetrace v0.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timetrace create record panics because of nil pointer dereference

3 participants