Skip to content

Add decimal time#180

Merged
dominikbraun merged 5 commits intodominikbraun:mainfrom
mattkasun:add-decimal-time
Sep 14, 2021
Merged

Add decimal time#180
dominikbraun merged 5 commits intodominikbraun:mainfrom
mattkasun:add-decimal-time

Conversation

@mattkasun
Copy link
Copy Markdown
Contributor

Addresses Issue #179

display status/report in either default 8h 24min or decimal 8.4h or both 8h 24min 8.4h

@dominikbraun dominikbraun self-requested a review September 8, 2021 08:09
@dominikbraun
Copy link
Copy Markdown
Owner

Thanks for implementing this, @mattkasun! I'm going to review this PR soon.

@dominikbraun dominikbraun added this to the timetrace v0.14.0 milestone Sep 10, 2021
Copy link
Copy Markdown
Owner

@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good!

Comment thread config/config.go Outdated
@dominikbraun
Copy link
Copy Markdown
Owner

Nice! Feel free to disagree with me, but I personally prefer both over 2. If there are no objections left, I'm going to merge this. 👍

@dominikbraun dominikbraun self-requested a review September 13, 2021 06:08
@dominikbraun dominikbraun merged commit ccea76d into dominikbraun:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants