Skip to content

fix: avoid cache in parse extends#161

Closed
patak-cat wants to merge 3 commits intodominikg:mainfrom
patak-cat:fix/avoid-cache-in-parse-extends
Closed

fix: avoid cache in parse extends#161
patak-cat wants to merge 3 commits intodominikg:mainfrom
patak-cat:fix/avoid-cache-in-parse-extends

Conversation

@patak-cat
Copy link
Copy Markdown

I don't think this is a long term solution, but we could do something like this to avoid the issue with extends until we have a better strategy for the problem. IIUC, performance in general shouldn't be affected much as the config files will still end up in the cache when accessed. This only implies an extra cost while parsing the extends.

I commented out the tests that checked that the extended files were cached as that no longer holds.

@dominikg
Copy link
Copy Markdown
Owner

dominikg commented Mar 8, 2024

fixed via #165

@dominikg dominikg closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants