Closed
Conversation
Owner
Author
|
turns out 3.0.2 is already a lot slower than 3.0.1, this is actually getting some perf back. |
dominikg
commented
Feb 15, 2024
| let result; | ||
| if (filename !== tsconfigFile && cache?.hasParseResult(tsconfigFile)) { | ||
| result = await getParsedDeep(tsconfigFile, cache, options); | ||
| if (result.referenced?.then) { |
Owner
Author
There was a problem hiding this comment.
this is needed otherwise pnpm bench fails. However it shouldn't be. getParsedDeep awaits referenced, so i am not sure why it can still be a promise here...
There was a problem hiding this comment.
I can't understand why this is needed either. I think you could add a TODO to review this later? It won't harm perf for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problems
https://github.com/microsoft/TypeScript/blob/main/src/tsconfig.json#L9 references harness
https://github.com/microsoft/TypeScript/blob/main/src/harness/tsconfig.json#L10 references others