adds a customization for how much of the filename gets truncated#289
Open
cbbaker wants to merge 1 commit intodominikh:masterfrom
Open
adds a customization for how much of the filename gets truncated#289cbbaker wants to merge 1 commit intodominikh:masterfrom
cbbaker wants to merge 1 commit intodominikh:masterfrom
Conversation
The length of the filename in the go guru output was hardcoded to 20, and I wanted it longer, so I added a customization.
Contributor
|
Can you rebase or squash this PR to get rid of the extra merge commit? |
Author
|
I think I did this right. Let me know :) |
dominikh
reviewed
Dec 15, 2021
| (let* ((posn (buffer-substring-no-properties start p)) | ||
| (flen (cl-search ":" posn)) ; length of filename | ||
| (filename (if (< flen 19) | ||
| (truncate (- (max go-guru-truncate-file-length 20) 1)) |
Owner
There was a problem hiding this comment.
I don't understand the use of max here. Can we not truncate to less than 20 characters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The length of the filename in the go guru output was hardcoded to 20,
and I wanted it longer, so I added a customization.